[GitHub] [geode] pivotal-jbarrett commented on a diff in pull request #7737: GEODE-10301: support LocalDate and JodaTime

[GitBox <gi...@apache.org>]

pivotal-jbarrett commented on code in PR #7737:
URL: https://github.com/apache/geode/pull/7737#discussion_r887221766


##########
build-tools/geode-dependency-management/src/main/groovy/org/apache/geode/gradle/plugins/DependencyConstraints.groovy:
##########
@@ -46,6 +46,7 @@ class DependencyConstraints {
     deps.put("jboss-modules.version", "1.11.0.Final")
     deps.put("jackson.version", "2.13.2")
     deps.put("jackson.databind.version", "2.13.2.2")
+    deps.put("joda-time.version", "2.10.14")

Review Comment:
   The indirection is excessive when there isn't multiple modules for a similar version number or any other need for the version number to be known outside the constraints.



##########
geode-core/src/test/java/org/apache/geode/management/internal/json/QueryResultFormatterTest.java:
##########
@@ -31,6 +31,7 @@
 
 import com.fasterxml.jackson.databind.JsonNode;
 import com.fasterxml.jackson.databind.ObjectMapper;
+import org.joda.time.DateTime;
 import org.junit.Test;

Review Comment:
   Please convert unit test to JUnit 5.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@geode.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org