You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@lucy.apache.org by "Nick Wellnhofer (JIRA)" <ji...@apache.org> on 2016/03/08 13:56:40 UTC

[lucy-issues] [jira] [Commented] (CLOWNFISH-67) Check for circular references in Vec_Equals and Hash_Equals

    [ https://issues.apache.org/jira/browse/CLOWNFISH-67?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15184872#comment-15184872 ] 

Nick Wellnhofer commented on CLOWNFISH-67:
------------------------------------------

I think we should remove the feature to deeply compare Vectors and Hashes from Clownfish, just like we removed deep cloning. One possible approach:

- Make Vec_Equals and Hash_Equals compare Vectors and Hashes by address.
- Add methods like Vec_Contents_Equal and Hash_Contents_Equal that perform a shallow comparison of two Vectors' and Hashes' contents using Obj_Equals.

> Check for circular references in Vec_Equals and Hash_Equals
> -----------------------------------------------------------
>
>                 Key: CLOWNFISH-67
>                 URL: https://issues.apache.org/jira/browse/CLOWNFISH-67
>             Project: Apache Lucy-Clownfish
>          Issue Type: Bug
>          Components: Core
>            Reporter: Nick Wellnhofer
>            Priority: Minor
>
> Similar to CLOWNFISH-36, circular references in Vectors and Hashes can lead to the Equals method looping infinitely.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)