[GitHub] [skywalking] lujiajing1126 commented on a diff in pull request #10180: Fix cannot display attached events when using Zipkin Lens UI query traces

[GitBox <gi...@apache.org>]

lujiajing1126 commented on code in PR #10180:
URL: https://github.com/apache/skywalking/pull/10180#discussion_r1051916589


##########
oap-server/server-storage-plugin/storage-banyandb-plugin/src/main/java/org/apache/skywalking/oap/server/storage/plugin/banyandb/stream/BanyanDBSpanAttachedEventQueryDAO.java:
##########
@@ -51,11 +51,11 @@ public BanyanDBSpanAttachedEventQueryDAO(BanyanDBStorageClient client) {
     }
 
     @Override
-    public List<SpanAttachedEventRecord> querySpanAttachedEvents(SpanAttachedEventTraceType type, String traceId) throws IOException {
+    public List<SpanAttachedEventRecord> querySpanAttachedEvents(SpanAttachedEventTraceType type, List<String> traceIds) throws IOException {
         final StreamQueryResponse resp = query(SpanAttachedEventRecord.INDEX_NAME, TAGS, new QueryBuilder<StreamQuery>() {
             @Override
             protected void apply(StreamQuery query) {
-                query.and(eq(SpanAttachedEventRecord.RELATED_TRACE_ID, traceId));
+                query.and(having(SpanAttachedEventRecord.RELATED_TRACE_ID, traceIds));

Review Comment:
   > @lujiajing1126 Could you follow this?
   
   Oh, I didn't notice this PR.
   
   > @hanahmily @lujiajing1126 Should we use `have` or `or`? Or the latest `in`?
   
   From the semantics, it should be `in` here. `having` means subset, usually for `Set`/`List` typed tag.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org