You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@paimon.apache.org by "zhuangchong (via GitHub)" <gi...@apache.org> on 2023/09/26 02:52:12 UTC
[GitHub] [incubator-paimon] zhuangchong commented on a diff in pull request #2053: [cdc] Refactor mysql debezium json event parser
zhuangchong commented on code in PR #2053:
URL: https://github.com/apache/incubator-paimon/pull/2053#discussion_r1336569853
##########
paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlDebeziumJsonEventParser.java:
##########
@@ -113,7 +113,7 @@ public MySqlDebeziumJsonEventParser(
caseSensitive,
computedColumns,
new TableNameConverter(caseSensitive),
- ddl -> Optional.empty(),
+ new MySqlTableSchemaBuilder(new HashMap<>(), caseSensitive, typeMapping),
Review Comment:
It's because I integrated the schema builder in change and new table, so the sync table action also requires the schema builder.
https://github.com/apache/incubator-paimon/blob/7b67e550d548c4297e05fee9e65795e849135f9f/paimon-flink/paimon-flink-cdc/src/main/java/org/apache/paimon/flink/action/cdc/mysql/MySqlDebeziumJsonEventParser.java#L208-L209
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: issues-unsubscribe@paimon.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org