You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@subversion.apache.org by Stefan <lu...@posteo.de> on 2016/05/16 11:19:12 UTC
[PATCH] clean up release notes
Hi,
following patch fixes some more W3C validation issues inside the release
notes
[[[
Make the release notes more compliant with the XHTML 1.1 standard.
* docs/release-notes/1.6.html
(Testsuite fails): add missing closing p-tag
* docs/release-notes/1.7.html
(svn diff can show git-style diff annotations): close p-tag before ul
* docs/release-notes/1.8.html
(Skelta style updates are now the default): drop invalid p-section
* docs/release-notes/1.9.html
(fsvnadmin pack): correct typo (missing / for closing tag)
(svnadmin setrevprop --transaction): fix incorrect closing tag
]]]
Regards,
Stefan
Re: [PATCH] clean up release notes
Posted by Stefan <lu...@posteo.de>.
On 5/16/2016 14:15, Branko Čibej wrote:
> On 16.05.2016 14:09, Stefan wrote:
>> On 5/16/2016 13:43, Branko Čibej wrote:
>>> On 16.05.2016 13:19, Stefan wrote:
>>>> Hi,
>>>>
>>>> following patch fixes some more W3C validation issues inside the release
>>>> notes
>>>>
>>>> [[[
>>>> Make the release notes more compliant with the XHTML 1.1 standard.
>>>>
>>>> * docs/release-notes/1.6.html
>>>> (Testsuite fails): add missing closing p-tag
>>>>
>>>> * docs/release-notes/1.7.html
>>>> (svn diff can show git-style diff annotations): close p-tag before ul
>>>>
>>>> * docs/release-notes/1.8.html
>>>> (Skelta style updates are now the default): drop invalid p-section
>>> What exactly did you do with the apostrophe in this file? It shows up as
>>> an invalid character for me ... note that the files have to be encoded
>>> in UTF-8, if your editor changes them to Latin-1, ditch your editor. :)
>>>
>>> See the first hunk in the diff (which, by the way, is not mentioned here
>>> in the log message.
>> Ouch. That was certainly unintended. Was caused by an incorrect setting
>> in WinMerge on my side (corrected and should no longer occur).
>>
>> Also I didn't intend to change the absence or presence of the BOM
>> (didn't realize my editor is set to drop that for html files).
>>
>> Both issues fixed with the attached patch.
> Looks good, please commit.
Committed in r1744038.
Regards,
Stefan
Re: [PATCH] clean up release notes
Posted by Branko Čibej <br...@apache.org>.
On 16.05.2016 14:09, Stefan wrote:
> On 5/16/2016 13:43, Branko \u010cibej wrote:
>> On 16.05.2016 13:19, Stefan wrote:
>>> Hi,
>>>
>>> following patch fixes some more W3C validation issues inside the release
>>> notes
>>>
>>> [[[
>>> Make the release notes more compliant with the XHTML 1.1 standard.
>>>
>>> * docs/release-notes/1.6.html
>>> (Testsuite fails): add missing closing p-tag
>>>
>>> * docs/release-notes/1.7.html
>>> (svn diff can show git-style diff annotations): close p-tag before ul
>>>
>>> * docs/release-notes/1.8.html
>>> (Skelta style updates are now the default): drop invalid p-section
>> What exactly did you do with the apostrophe in this file? It shows up as
>> an invalid character for me ... note that the files have to be encoded
>> in UTF-8, if your editor changes them to Latin-1, ditch your editor. :)
>>
>> See the first hunk in the diff (which, by the way, is not mentioned here
>> in the log message.
> Ouch. That was certainly unintended. Was caused by an incorrect setting
> in WinMerge on my side (corrected and should no longer occur).
>
> Also I didn't intend to change the absence or presence of the BOM
> (didn't realize my editor is set to drop that for html files).
>
> Both issues fixed with the attached patch.
Looks good, please commit.
-- Brane
Re: [PATCH] clean up release notes
Posted by Stefan <lu...@posteo.de>.
On 5/16/2016 13:43, Branko Čibej wrote:
> On 16.05.2016 13:19, Stefan wrote:
>> Hi,
>>
>> following patch fixes some more W3C validation issues inside the release
>> notes
>>
>> [[[
>> Make the release notes more compliant with the XHTML 1.1 standard.
>>
>> * docs/release-notes/1.6.html
>> (Testsuite fails): add missing closing p-tag
>>
>> * docs/release-notes/1.7.html
>> (svn diff can show git-style diff annotations): close p-tag before ul
>>
>> * docs/release-notes/1.8.html
>> (Skelta style updates are now the default): drop invalid p-section
> What exactly did you do with the apostrophe in this file? It shows up as
> an invalid character for me ... note that the files have to be encoded
> in UTF-8, if your editor changes them to Latin-1, ditch your editor. :)
>
> See the first hunk in the diff (which, by the way, is not mentioned here
> in the log message.
Ouch. That was certainly unintended. Was caused by an incorrect setting
in WinMerge on my side (corrected and should no longer occur).
Also I didn't intend to change the absence or presence of the BOM
(didn't realize my editor is set to drop that for html files).
Both issues fixed with the attached patch.
Regards,
Stefan
Re: [PATCH] clean up release notes
Posted by Branko Čibej <br...@apache.org>.
On 16.05.2016 13:19, Stefan wrote:
> Hi,
>
> following patch fixes some more W3C validation issues inside the release
> notes
>
> [[[
> Make the release notes more compliant with the XHTML 1.1 standard.
>
> * docs/release-notes/1.6.html
> (Testsuite fails): add missing closing p-tag
>
> * docs/release-notes/1.7.html
> (svn diff can show git-style diff annotations): close p-tag before ul
>
> * docs/release-notes/1.8.html
> (Skelta style updates are now the default): drop invalid p-section
What exactly did you do with the apostrophe in this file? It shows up as
an invalid character for me ... note that the files have to be encoded
in UTF-8, if your editor changes them to Latin-1, ditch your editor. :)
See the first hunk in the diff (which, by the way, is not mentioned here
in the log message.
> * docs/release-notes/1.9.html
> (fsvnadmin pack): correct typo (missing / for closing tag)
> (svnadmin setrevprop --transaction): fix incorrect closing tag
> ]]]
The rest of the changes look OK.
-- Brane