You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@flink.apache.org by zentol <gi...@git.apache.org> on 2018/02/06 13:11:42 UTC

[GitHub] flink pull request #5417: [FLINK-8565][tests] Ensure locationBytes.length > ...

GitHub user zentol opened a pull request:

    https://github.com/apache/flink/pull/5417

    [FLINK-8565][tests] Ensure locationBytes.length > 0 in CheckpointOptionsTest

    This PR fixes a test instability in `CheckpointOptionsTest#testSavepoint`. The tests generated a byte array of a random size, which may also be 0. This caused an `IllegalArgumentException` when being passed to the `CheckpointStorageLocationReference` constructor.
    
    We now add 1 to the randomly picked size, and compensate this addition by reducing the upper bound by 1.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/zentol/flink 8565

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/flink/pull/5417.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #5417
    
----
commit 6e22d496f0a92c93660f20e137e59cd30087e199
Author: zentol <ch...@...>
Date:   2018-02-06T13:07:23Z

    [FLINK-8565][tests] Ensure locationBytes.length > 0

----


---

[GitHub] flink issue #5417: [FLINK-8565][tests] Ensure locationBytes.length > 0 in Ch...

Posted by aljoscha <gi...@git.apache.org>.

Github user aljoscha commented on the issue:

    https://github.com/apache/flink/pull/5417
  
    LGTM! 👌 


---

[GitHub] flink pull request #5417: [FLINK-8565][tests] Ensure locationBytes.length > ...

Posted by asfgit <gi...@git.apache.org>.

Github user asfgit closed the pull request at:

    https://github.com/apache/flink/pull/5417


---