You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@carbondata.apache.org by ravipesala <gi...@git.apache.org> on 2017/11/06 08:10:57 UTC

[GitHub] carbondata pull request #1429: [CARBONDATA-1662] Make ArrayType and StructTy...

Github user ravipesala commented on a diff in the pull request:

    https://github.com/apache/carbondata/pull/1429#discussion_r149011985
  
    --- Diff: core/src/main/java/org/apache/carbondata/core/metadata/converter/ThriftWrapperSchemaConverterImpl.java ---
    @@ -392,9 +392,9 @@ private DataType fromExternalToWrapperDataType(org.apache.carbondata.format.Data
           case DATE:
             return DataTypes.DATE;
           case ARRAY:
    -        return DataTypes.ARRAY;
    +        return DataTypes.createDefaultArrayType();
    --- End diff --
    
    Can't we create actual array from the  child schemas here?


---