[GitHub] [hive] dengzhhu653 commented on a change in pull request #1757: HIVE-24511: Fix typo in SerDeStorageSchemaReader

[GitBox <gi...@apache.org>]

dengzhhu653 commented on a change in pull request #1757:
URL: https://github.com/apache/hive/pull/1757#discussion_r547042025



##########
File path: metastore/src/java/org/apache/hadoop/hive/metastore/SerDeStorageSchemaReader.java
##########
@@ -47,10 +48,10 @@
       Deserializer s = HiveMetaStoreUtils.getDeserializer(conf, tbl, false);
       return HiveMetaStoreUtils.getFieldsFromDeserializer(tbl.getTableName(), s);
     } catch (Exception e) {
-      StringUtils.stringifyException(e);
-      throw new MetaException(e.getMessage());
+      throw new MetaException(StringUtils.stringifyException(e));

Review comment:
       If the serde of the table is not a part of `metastore.serdes.using.metastore.for.schema`,  like JsonSerDe(openx).  MetaStore will use the defined serde to get the columns of the table. It's may be better to tell the caller that the exception happens when retrieving the columns from serde other than return null or an empty list, so the GetColumnsOperation can bring the exception to the front.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: gitbox-unsubscribe@hive.apache.org
For additional commands, e-mail: gitbox-help@hive.apache.org