You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ambari.apache.org by Arsen Babych <ab...@hortonworks.com> on 2014/02/10 18:04:48 UTC

Review Request 17909: Configuration on pushing Storm metrics to Ganglia.

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17909/
-----------------------------------------------------------

Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Nate Cole.


Bugs: AMBARI-4578
    https://issues.apache.org/jira/browse/AMBARI-4578


Repository: ambari


Description
-------

Configuration on pushing Storm metrics to Ganglia.


Diffs
-----

  ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 a6a66ef 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 4abdb9b 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 863f092 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py 601601e 
  ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/gangliaClusters.conf.j2 f3bb355 
  ambari-web/app/data/HDP2/site_properties.js 8ef5a95 

Diff: https://reviews.apache.org/r/17909/diff/


Testing
-------


Thanks,

Arsen Babych


Re: Review Request 17909: Configuration on pushing Storm metrics to Ganglia.

Posted by Nate Cole <nc...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17909/#review34084
-----------------------------------------------------------

Ship it!


Ship It!

- Nate Cole


On Feb. 10, 2014, 12:04 p.m., Arsen Babych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17909/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 12:04 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Nate Cole.
> 
> 
> Bugs: AMBARI-4578
>     https://issues.apache.org/jira/browse/AMBARI-4578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Configuration on pushing Storm metrics to Ganglia.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 a6a66ef 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 4abdb9b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 863f092 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py 601601e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/gangliaClusters.conf.j2 f3bb355 
>   ambari-web/app/data/HDP2/site_properties.js 8ef5a95 
> 
> Diff: https://reviews.apache.org/r/17909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arsen Babych
> 
>


Re: Review Request 17909: Configuration on pushing Storm metrics to Ganglia.

Posted by Mahadev Konar <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17909/#review34205
-----------------------------------------------------------

Ship it!


Ship It!

- Mahadev Konar


On Feb. 10, 2014, 5:04 p.m., Arsen Babych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17909/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 5:04 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Nate Cole.
> 
> 
> Bugs: AMBARI-4578
>     https://issues.apache.org/jira/browse/AMBARI-4578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Configuration on pushing Storm metrics to Ganglia.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 a6a66ef 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 4abdb9b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 863f092 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py 601601e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/gangliaClusters.conf.j2 f3bb355 
>   ambari-web/app/data/HDP2/site_properties.js 8ef5a95 
> 
> Diff: https://reviews.apache.org/r/17909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arsen Babych
> 
>


Re: Review Request 17909: Configuration on pushing Storm metrics to Ganglia.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17909/#review34083
-----------------------------------------------------------


Please add nimbus,supervisor hosts to test jsons, and edit the code to test the changes.

- Andrew Onischuk


On Feb. 10, 2014, 5:04 p.m., Arsen Babych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17909/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 5:04 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Nate Cole.
> 
> 
> Bugs: AMBARI-4578
>     https://issues.apache.org/jira/browse/AMBARI-4578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Configuration on pushing Storm metrics to Ganglia.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 a6a66ef 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 4abdb9b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 863f092 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py 601601e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/gangliaClusters.conf.j2 f3bb355 
>   ambari-web/app/data/HDP2/site_properties.js 8ef5a95 
> 
> Diff: https://reviews.apache.org/r/17909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arsen Babych
> 
>


Re: Review Request 17909: Configuration on pushing Storm metrics to Ganglia.

Posted by Andrew Onischuk <ao...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/17909/#review34082
-----------------------------------------------------------

Ship it!


Ship It!

- Andrew Onischuk


On Feb. 10, 2014, 5:04 p.m., Arsen Babych wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/17909/
> -----------------------------------------------------------
> 
> (Updated Feb. 10, 2014, 5:04 p.m.)
> 
> 
> Review request for Ambari, Andrew Onischuk, Mahadev Konar, and Nate Cole.
> 
> 
> Bugs: AMBARI-4578
>     https://issues.apache.org/jira/browse/AMBARI-4578
> 
> 
> Repository: ambari
> 
> 
> Description
> -------
> 
> Configuration on pushing Storm metrics to Ganglia.
> 
> 
> Diffs
> -----
> 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/hooks/before-START/templates/hadoop-metrics2.properties.j2 a6a66ef 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_monitor.py 4abdb9b 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/ganglia_server.py 863f092 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/scripts/params.py 601601e 
>   ambari-server/src/main/resources/stacks/HDP/2.0.6/services/GANGLIA/package/templates/gangliaClusters.conf.j2 f3bb355 
>   ambari-web/app/data/HDP2/site_properties.js 8ef5a95 
> 
> Diff: https://reviews.apache.org/r/17909/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Arsen Babych
> 
>