You are viewing a plain text version of this content. The canonical link for it is here.

Posted to issues@bookkeeper.apache.org by GitBox <gi...@apache.org> on 2021/09/23 21:00:18 UTC

[GitHub] [bookkeeper] dlg99 commented on a change in pull request #2794: Heap memory leak problem when ledger replication failed

dlg99 commented on a change in pull request #2794:
URL: https://github.com/apache/bookkeeper/pull/2794#discussion_r715150149



##########
File path: bookkeeper-server/src/main/java/org/apache/bookkeeper/client/LedgerOpenOp.java
##########
@@ -196,8 +196,28 @@ public void safeOperationComplete(int rc, Void result) {
                     if (rc == BKException.Code.OK) {
                         openComplete(BKException.Code.OK, lh);
                     } else if (rc == BKException.Code.UnauthorizedAccessException) {
+                        try {

Review comment:
       i'd refactor this into something like `closeLedger(LedgerHandle lh)`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@bookkeeper.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org