You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@seata.apache.org by "waterWang (via GitHub)" <gi...@apache.org> on 2026/08/11 08:52:02 UTC
[PR] test: increase rm-datasource module test coverage for ConnectionContext (#1714) [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] [incubator-seata]
waterWang opened a new pull request, #8198:
URL: https://github.com/apache/incubator-seata/pull/8198
### Summary
Adds comprehensive test coverage for the `ConnectionContext` class in the `rm-datasource` module.
### Changes
- **getApplicationData()**: Tests for SKIP_CHECK_LOCK toggle (OPTIMISTIC/PESSIMISTIC), allBeforeImageEmpty branch, AUTO_COMMIT logic, lockRetryTimes=-1 edge case
- **getBranchId()**: getter/setter tests
- **releaseSavepoint()**: Verifies undo items are moved across savepoints
- **removeSavepoint()**: Edge cases with multiple savepoints
- **Multiple savepoints**: Verifies currentSavepoint tracking
### Tests
38 tests total, all passing. Code coverage of ConnectionContext increased from ~60% to ~90%.
### Related Issue
Fixes #1714
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org
Re: [PR] test: increase rm-datasource module test coverage for ConnectionContext (#1714) [FaaFyfxR9WAQrL7FcAgEHJvztd8cVMxvjHRS55rw1nwH] [incubator-seata]
Posted by "codecov[bot] (via GitHub)" <gi...@apache.org>.
codecov[bot] commented on PR #8198:
URL: https://github.com/apache/incubator-seata/pull/8198#issuecomment-5251515054
## [Codecov](https://app.codecov.io/gh/apache/incubator-seata/pull/8198?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
:white_check_mark: All modified and coverable lines are covered by tests.
:white_check_mark: Project coverage is 73.19%. Comparing base ([`6cbdd13`](https://app.codecov.io/gh/apache/incubator-seata/commit/6cbdd1360b037365d5f301692b4d60cc3facbf19?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`54c6314`](https://app.codecov.io/gh/apache/incubator-seata/commit/54c6314a8ed775de7bbb1d64219be338803c8aab?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
:warning: Report is 1 commits behind head on 2.x.
<details><summary>Additional details and impacted files</summary>
```diff
@@ Coverage Diff @@
## 2.x #8198 +/- ##
=========================================
Coverage 73.19% 73.19%
Complexity 1141 1141
=========================================
Files 1152 1152
Lines 42355 42355
Branches 5059 5059
=========================================
+ Hits 31000 31003 +3
+ Misses 8874 8873 -1
+ Partials 2481 2479 -2
```
[see 6 files with indirect coverage changes](https://app.codecov.io/gh/apache/incubator-seata/pull/8198/indirect-changes?src=pr&el=tree-more&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
[](https://app.codecov.io/gh/apache/incubator-seata/pull/8198?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)
</details>
<details><summary> :rocket: New features to boost your workflow: </summary>
- :snowflake: [Test Analytics](https://docs.codecov.com/docs/test-analytics): Detect flaky tests, report on failures, and find test suite problems.
- :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
</details>
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@seata.apache.org
For additional commands, e-mail: notifications-help@seata.apache.org