[jira] [Commented] (HADOOP-13186) GenericOptionParser -libjars option validity check not always working because of bad local FS equality check

["Hudson (JIRA)" <ji...@apache.org>]

    [ https://issues.apache.org/jira/browse/HADOOP-13186?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16515193#comment-16515193 ] 

Hudson commented on HADOOP-13186:
---------------------------------

SUCCESS: Integrated in Jenkins build Hadoop-trunk-Commit #14443 (See [https://builds.apache.org/job/Hadoop-trunk-Commit/14443/])
HADOOP-13186. Multipart Uploader API. Contributed by Ewan Higgs (cdouglas: rev 980031bb043dd026a6bf42b0e71d304ac89294a5)
* (add) hadoop-tools/hadoop-aws/src/main/java/org/apache/hadoop/fs/s3a/S3AMultipartUploader.java
* (add) hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/fs/TestHDFSMultipartUploader.java
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BBPartHandle.java
* (edit) hadoop-common-project/hadoop-common/src/test/resources/contract/rawlocal.xml
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/FileSystemMultipartUploader.java
* (edit) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/AbstractContractPathHandleTest.java
* (add) hadoop-tools/hadoop-aws/src/main/resources/META-INF/services/org.apache.hadoop.fs.MultipartUploader
* (add) hadoop-tools/hadoop-aws/src/main/resources/META-INF/org.apache.hadoop.fs.MultipartUploaderFactory
* (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/TestLocalFileSystemMultipartUploader.java
* (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/resources/META-INF/services/org.apache.hadoop.fs.MultipartUploaderFactory
* (add) hadoop-common-project/hadoop-common/src/main/resources/META-INF/services/org.apache.hadoop.fs.MultipartUploaderFactory
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/UploadHandle.java
* (edit) hadoop-common-project/hadoop-common/src/main/proto/FSProtos.proto
* (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/AbstractSystemMultipartUploaderTest.java
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/BBUploadHandle.java
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/UnsupportedMultipartUploaderException.java
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/LocalFileSystemPathHandle.java
* (edit) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/RawLocalFileSystem.java
* (add) hadoop-common-project/hadoop-common/src/test/java/org/apache/hadoop/fs/contract/rawlocal/TestRawlocalContractPathHandle.java
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MultipartUploader.java
* (add) hadoop-hdfs-project/hadoop-hdfs-client/src/main/java/org/apache/hadoop/hdfs/DFSMultipartUploaderFactory.java
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/MultipartUploaderFactory.java
* (add) hadoop-common-project/hadoop-common/src/main/java/org/apache/hadoop/fs/PartHandle.java


> GenericOptionParser -libjars option validity check not always working because of bad local FS equality check
> ------------------------------------------------------------------------------------------------------------
>
>                 Key: HADOOP-13186
>                 URL: https://issues.apache.org/jira/browse/HADOOP-13186
>             Project: Hadoop Common
>          Issue Type: Bug
>          Components: util
>    Affects Versions: 2.6.0, 2.7.1
>         Environment: Occured on: CentOS 6.3 or Ubuntu 14.04, Oracle JDK 1.7.0_45 or 1.8.0_66
>            Reporter: Arnaud Linz
>            Priority: Major
>   Original Estimate: 24h
>  Remaining Estimate: 24h
>
> _Class concerned :_
> {{org.apache.hadoop.util.GenericOptionParser}}
> _Method :_
> {{public static URL[] getLibJars(final Configuration conf)}}
> _Line :_
> {{if (tmp.getFileSystem(conf).equals(FileSystem.getLocal(conf)))}}
> In this method we check if the provided jar on the command line are on a local file system, else we emit a warning log and ignore it.
> I've got the case where the two file systems retrieved (the one from the {{Path.getFileSystem(conf)}} and the one returned by {{FileSystem.getLocal(conf)}}) where two local file systems but different objects, and the {{equals()}} method, not having been implemented, defaulted to the object pointer equality, leading to my jar files not being taken into account.
> I've quickly patched it to 
> {{tmp.getFileSystem(conf).getUri().equals(FileSystem.getLocal(conf).getUri()}}
> to have my application work.
> I did not dig further into determining whether the objects should have been the same, or whether the {{equals()}} method should have been implemented, but it has to be done.



--
This message was sent by Atlassian JIRA
(v7.6.3#76005)

---------------------------------------------------------------------
To unsubscribe, e-mail: common-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: common-issues-help@hadoop.apache.org