You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@spark.apache.org by GitBox <gi...@apache.org> on 2021/08/05 16:18:01 UTC
[GitHub] [spark] cloud-fan commented on a change in pull request #33566: [SPARK-36271][SQL] Unify V1 insert check field name before prepare writter
cloud-fan commented on a change in pull request #33566:
URL: https://github.com/apache/spark/pull/33566#discussion_r683601646
##########
File path: sql/hive/src/test/scala/org/apache/spark/sql/hive/execution/HiveDDLSuite.scala
##########
@@ -2960,6 +2960,28 @@ class HiveDDLSuite
}
}
+ test("SPARK-36271: V1 insert should check schema field name too") {
Review comment:
is it hive-related? Why not put the test in `sql/core`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org