You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@jmeter.apache.org by Philippe Mouawad <ph...@gmail.com> on 2018/01/30 21:17:28 UTC

Re: svn commit: r1822696 - /jmeter/trunk/build.xml

Should't we force this also in jmeter-server ?

Thanks

On Tue, Jan 30, 2018 at 9:22 PM, <fs...@apache.org> wrote:

> Author: fschumacher
> Date: Tue Jan 30 20:22:52 2018
> New Revision: 1822696
>
> URL: http://svn.apache.org/viewvc?rev=1822696&view=rev
> Log:
> We now have more tests, that depend on rmi, so add the rmi_force_localhost
> option to those cases.
>
> Modified:
>     jmeter/trunk/build.xml
>
> Modified: jmeter/trunk/build.xml
> URL: http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=
> 1822696&r1=1822695&r2=1822696&view=diff
> ============================================================
> ==================
> --- jmeter/trunk/build.xml (original)
> +++ jmeter/trunk/build.xml Tue Jan 30 20:22:52 2018
> @@ -129,6 +129,8 @@
>    <property name="skip.test_http" value="false" />
>    <property name="skip.test_TestDNSCacheManager.
> testWithCustomResolverAnd1Server" value="false" />
>
> +  <exec executable="hostname" outputproperty="computer.hostname"/>
> +
>    <target name="findbugs" description="Run the stand-alone Findbugs
> detector">
>      <echoproperties prefix="findbugs"/>
>      <mkdir dir="reports"/>
> @@ -2589,7 +2591,6 @@ run JMeter unless all the JMeter jars ar
>      <property name="batchtestserver.out" location="${basedir}/bin"/>
>      <property name="batchtestserver.log" value="BatchTestServer.log"/>
>      <!-- rmi_force_localhost is used by the Travis build -->
> -    <exec executable="hostname" outputproperty="computer.hostname"/>
>      <condition property="rmi_hostname_option" value="-Ddummy=true">
>        <not><isset property="rmi_force_localhost"/></not>
>      </condition>
> @@ -2728,6 +2729,7 @@ run JMeter unless all the JMeter jars ar
>        <jvmarg value="--add-modules" if:set="java9" />
>        <jvmarg value="java.activation" if:set="java9" />
>        <jvmarg value="${jacoco_params}batchtest:java(${taskname})"/>
> +      <jvmarg value="-Djava.rmi.server.hostname=${computer.hostname}"
> if:set="rmi_force_localhost"/>
>        <!-- Detect if non-GUI runs OK headless by forcing it to try using
> non-headless mode -->
>        <sysproperty key="user.language" value="en"/>
>        <sysproperty key="user.region" value="US"/>
> @@ -3069,6 +3071,7 @@ run JMeter unless all the JMeter jars ar
>        <jvmarg value="-server"/>
>        <jvmarg value="${jacoco_params}_test:java"/>
>        <jvmarg value="-Dfile.encoding=${test.encoding}"/>
> +      <jvmarg value="-Djava.rmi.server.hostname=${computer.hostname}"
> if:set="rmi_force_localhost"/>
>        <sysproperty key="java.awt.headless" value="${test.headless}"/>
>        <sysproperty key="testsaveservice.saveout" value="${testsaveservice.saveout}"
> />
>        <sysproperty key="gump.run" value="${gump.run}" />
>
>
>


-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1822696 - /jmeter/trunk/build.xml

Posted by Felix Schumacher <fe...@internetallee.de>.
Am 31.01.2018 um 16:44 schrieb Philippe Mouawad:
> Hi Felix,
> My idea was to uncomment in jmeter-server.sh (.bat):
> #RMI_HOST_DEF=-Djava.rmi.server.hostname=xxx.xxx.xxx.xxx
What do you want to put for xxx.xxx?

The changes in build.xml where made to get travis ci back to green and 
(not successfully) to get nightly back to work.

Travis uses a hostname that is mapped to localhost and that's why the 
rmi servername has to be set.

Felix
>
> Regards
>
> On Wed, Jan 31, 2018 at 6:31 AM, Felix Schumacher <
> felix.schumacher@internetallee.de> wrote:
>
>>
>> Am 30. Januar 2018 22:17:28 MEZ schrieb Philippe Mouawad <
>> philippe.mouawad@gmail.com>:
>>> Should't we force this also in jmeter-server ?
>> Might be too early, but at the moment I don't understand what you want to
>> do.
>>
>> Felix
>>
>>> Thanks
>>>
>>> On Tue, Jan 30, 2018 at 9:22 PM, <fs...@apache.org> wrote:
>>>
>>>> Author: fschumacher
>>>> Date: Tue Jan 30 20:22:52 2018
>>>> New Revision: 1822696
>>>>
>>>> URL: http://svn.apache.org/viewvc?rev=1822696&view=rev
>>>> Log:
>>>> We now have more tests, that depend on rmi, so add the
>>> rmi_force_localhost
>>>> option to those cases.
>>>>
>>>> Modified:
>>>>      jmeter/trunk/build.xml
>>>>
>>>> Modified: jmeter/trunk/build.xml
>>>> URL: http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=
>>>> 1822696&r1=1822695&r2=1822696&view=diff
>>>> ============================================================
>>>> ==================
>>>> --- jmeter/trunk/build.xml (original)
>>>> +++ jmeter/trunk/build.xml Tue Jan 30 20:22:52 2018
>>>> @@ -129,6 +129,8 @@
>>>>     <property name="skip.test_http" value="false" />
>>>>     <property name="skip.test_TestDNSCacheManager.
>>>> testWithCustomResolverAnd1Server" value="false" />
>>>>
>>>> +  <exec executable="hostname" outputproperty="computer.hostname"/>
>>>> +
>>>>     <target name="findbugs" description="Run the stand-alone Findbugs
>>>> detector">
>>>>       <echoproperties prefix="findbugs"/>
>>>>       <mkdir dir="reports"/>
>>>> @@ -2589,7 +2591,6 @@ run JMeter unless all the JMeter jars ar
>>>>       <property name="batchtestserver.out" location="${basedir}/bin"/>
>>>>       <property name="batchtestserver.log"
>>> value="BatchTestServer.log"/>
>>>>       <!-- rmi_force_localhost is used by the Travis build -->
>>>> -    <exec executable="hostname" outputproperty="computer.hostname"/>
>>>>       <condition property="rmi_hostname_option" value="-Ddummy=true">
>>>>         <not><isset property="rmi_force_localhost"/></not>
>>>>       </condition>
>>>> @@ -2728,6 +2729,7 @@ run JMeter unless all the JMeter jars ar
>>>>         <jvmarg value="--add-modules" if:set="java9" />
>>>>         <jvmarg value="java.activation" if:set="java9" />
>>>>         <jvmarg value="${jacoco_params}batchtest:java(${taskname})"/>
>>>> +      <jvmarg
>>> value="-Djava.rmi.server.hostname=${computer.hostname}"
>>>> if:set="rmi_force_localhost"/>
>>>>         <!-- Detect if non-GUI runs OK headless by forcing it to try
>>> using
>>>> non-headless mode -->
>>>>         <sysproperty key="user.language" value="en"/>
>>>>         <sysproperty key="user.region" value="US"/>
>>>> @@ -3069,6 +3071,7 @@ run JMeter unless all the JMeter jars ar
>>>>         <jvmarg value="-server"/>
>>>>         <jvmarg value="${jacoco_params}_test:java"/>
>>>>         <jvmarg value="-Dfile.encoding=${test.encoding}"/>
>>>> +      <jvmarg
>>> value="-Djava.rmi.server.hostname=${computer.hostname}"
>>>> if:set="rmi_force_localhost"/>
>>>>         <sysproperty key="java.awt.headless"
>>> value="${test.headless}"/>
>>>>         <sysproperty key="testsaveservice.saveout"
>>> value="${testsaveservice.saveout}"
>>>> />
>>>>         <sysproperty key="gump.run" value="${gump.run}" />
>>>>
>>>>
>>>>
>
>


Re: svn commit: r1822696 - /jmeter/trunk/build.xml

Posted by Philippe Mouawad <ph...@gmail.com>.
Hi Felix,
My idea was to uncomment in jmeter-server.sh (.bat):
#RMI_HOST_DEF=-Djava.rmi.server.hostname=xxx.xxx.xxx.xxx

Regards

On Wed, Jan 31, 2018 at 6:31 AM, Felix Schumacher <
felix.schumacher@internetallee.de> wrote:

>
>
> Am 30. Januar 2018 22:17:28 MEZ schrieb Philippe Mouawad <
> philippe.mouawad@gmail.com>:
> >Should't we force this also in jmeter-server ?
>
> Might be too early, but at the moment I don't understand what you want to
> do.
>
> Felix
>
> >
> >Thanks
> >
> >On Tue, Jan 30, 2018 at 9:22 PM, <fs...@apache.org> wrote:
> >
> >> Author: fschumacher
> >> Date: Tue Jan 30 20:22:52 2018
> >> New Revision: 1822696
> >>
> >> URL: http://svn.apache.org/viewvc?rev=1822696&view=rev
> >> Log:
> >> We now have more tests, that depend on rmi, so add the
> >rmi_force_localhost
> >> option to those cases.
> >>
> >> Modified:
> >>     jmeter/trunk/build.xml
> >>
> >> Modified: jmeter/trunk/build.xml
> >> URL: http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=
> >> 1822696&r1=1822695&r2=1822696&view=diff
> >> ============================================================
> >> ==================
> >> --- jmeter/trunk/build.xml (original)
> >> +++ jmeter/trunk/build.xml Tue Jan 30 20:22:52 2018
> >> @@ -129,6 +129,8 @@
> >>    <property name="skip.test_http" value="false" />
> >>    <property name="skip.test_TestDNSCacheManager.
> >> testWithCustomResolverAnd1Server" value="false" />
> >>
> >> +  <exec executable="hostname" outputproperty="computer.hostname"/>
> >> +
> >>    <target name="findbugs" description="Run the stand-alone Findbugs
> >> detector">
> >>      <echoproperties prefix="findbugs"/>
> >>      <mkdir dir="reports"/>
> >> @@ -2589,7 +2591,6 @@ run JMeter unless all the JMeter jars ar
> >>      <property name="batchtestserver.out" location="${basedir}/bin"/>
> >>      <property name="batchtestserver.log"
> >value="BatchTestServer.log"/>
> >>      <!-- rmi_force_localhost is used by the Travis build -->
> >> -    <exec executable="hostname" outputproperty="computer.hostname"/>
> >>      <condition property="rmi_hostname_option" value="-Ddummy=true">
> >>        <not><isset property="rmi_force_localhost"/></not>
> >>      </condition>
> >> @@ -2728,6 +2729,7 @@ run JMeter unless all the JMeter jars ar
> >>        <jvmarg value="--add-modules" if:set="java9" />
> >>        <jvmarg value="java.activation" if:set="java9" />
> >>        <jvmarg value="${jacoco_params}batchtest:java(${taskname})"/>
> >> +      <jvmarg
> >value="-Djava.rmi.server.hostname=${computer.hostname}"
> >> if:set="rmi_force_localhost"/>
> >>        <!-- Detect if non-GUI runs OK headless by forcing it to try
> >using
> >> non-headless mode -->
> >>        <sysproperty key="user.language" value="en"/>
> >>        <sysproperty key="user.region" value="US"/>
> >> @@ -3069,6 +3071,7 @@ run JMeter unless all the JMeter jars ar
> >>        <jvmarg value="-server"/>
> >>        <jvmarg value="${jacoco_params}_test:java"/>
> >>        <jvmarg value="-Dfile.encoding=${test.encoding}"/>
> >> +      <jvmarg
> >value="-Djava.rmi.server.hostname=${computer.hostname}"
> >> if:set="rmi_force_localhost"/>
> >>        <sysproperty key="java.awt.headless"
> >value="${test.headless}"/>
> >>        <sysproperty key="testsaveservice.saveout"
> >value="${testsaveservice.saveout}"
> >> />
> >>        <sysproperty key="gump.run" value="${gump.run}" />
> >>
> >>
> >>
>



-- 
Cordialement.
Philippe Mouawad.

Re: svn commit: r1822696 - /jmeter/trunk/build.xml

Posted by Felix Schumacher <fe...@internetallee.de>.

Am 30. Januar 2018 22:17:28 MEZ schrieb Philippe Mouawad <ph...@gmail.com>:
>Should't we force this also in jmeter-server ?

Might be too early, but at the moment I don't understand what you want to do.

Felix

>
>Thanks
>
>On Tue, Jan 30, 2018 at 9:22 PM, <fs...@apache.org> wrote:
>
>> Author: fschumacher
>> Date: Tue Jan 30 20:22:52 2018
>> New Revision: 1822696
>>
>> URL: http://svn.apache.org/viewvc?rev=1822696&view=rev
>> Log:
>> We now have more tests, that depend on rmi, so add the
>rmi_force_localhost
>> option to those cases.
>>
>> Modified:
>>     jmeter/trunk/build.xml
>>
>> Modified: jmeter/trunk/build.xml
>> URL: http://svn.apache.org/viewvc/jmeter/trunk/build.xml?rev=
>> 1822696&r1=1822695&r2=1822696&view=diff
>> ============================================================
>> ==================
>> --- jmeter/trunk/build.xml (original)
>> +++ jmeter/trunk/build.xml Tue Jan 30 20:22:52 2018
>> @@ -129,6 +129,8 @@
>>    <property name="skip.test_http" value="false" />
>>    <property name="skip.test_TestDNSCacheManager.
>> testWithCustomResolverAnd1Server" value="false" />
>>
>> +  <exec executable="hostname" outputproperty="computer.hostname"/>
>> +
>>    <target name="findbugs" description="Run the stand-alone Findbugs
>> detector">
>>      <echoproperties prefix="findbugs"/>
>>      <mkdir dir="reports"/>
>> @@ -2589,7 +2591,6 @@ run JMeter unless all the JMeter jars ar
>>      <property name="batchtestserver.out" location="${basedir}/bin"/>
>>      <property name="batchtestserver.log"
>value="BatchTestServer.log"/>
>>      <!-- rmi_force_localhost is used by the Travis build -->
>> -    <exec executable="hostname" outputproperty="computer.hostname"/>
>>      <condition property="rmi_hostname_option" value="-Ddummy=true">
>>        <not><isset property="rmi_force_localhost"/></not>
>>      </condition>
>> @@ -2728,6 +2729,7 @@ run JMeter unless all the JMeter jars ar
>>        <jvmarg value="--add-modules" if:set="java9" />
>>        <jvmarg value="java.activation" if:set="java9" />
>>        <jvmarg value="${jacoco_params}batchtest:java(${taskname})"/>
>> +      <jvmarg
>value="-Djava.rmi.server.hostname=${computer.hostname}"
>> if:set="rmi_force_localhost"/>
>>        <!-- Detect if non-GUI runs OK headless by forcing it to try
>using
>> non-headless mode -->
>>        <sysproperty key="user.language" value="en"/>
>>        <sysproperty key="user.region" value="US"/>
>> @@ -3069,6 +3071,7 @@ run JMeter unless all the JMeter jars ar
>>        <jvmarg value="-server"/>
>>        <jvmarg value="${jacoco_params}_test:java"/>
>>        <jvmarg value="-Dfile.encoding=${test.encoding}"/>
>> +      <jvmarg
>value="-Djava.rmi.server.hostname=${computer.hostname}"
>> if:set="rmi_force_localhost"/>
>>        <sysproperty key="java.awt.headless"
>value="${test.headless}"/>
>>        <sysproperty key="testsaveservice.saveout"
>value="${testsaveservice.saveout}"
>> />
>>        <sysproperty key="gump.run" value="${gump.run}" />
>>
>>
>>