You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cloudstack.apache.org by nlivens <gi...@git.apache.org> on 2015/12/07 16:07:44 UTC
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
GitHub user nlivens opened a pull request:
https://github.com/apache/cloudstack/pull/1185
Adapted HypervisorUtilsTest to no longer give false positives
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/nlivens/cloudstack test_improvement
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cloudstack/pull/1185.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #1185
----
commit 994ce15c743fc0dc277e089f6240b7c09caed219
Author: Nick Livens <ni...@nuagenetworks.net>
Date: 2015-12-07T15:04:41Z
Adapted HypervisorUtilsTest to no longer give false positives
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-163590671
LGTM, I hit the unit test failure today with Jenkins while building master branch (4.7) and @nlivens 's fix worked for me :)
cc @DaanHoogland @remibergsma pl do merge this
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Posted by nlivens <gi...@git.apache.org>.
Github user nlivens commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162551073
@bhaisaab, this is the PR for the test adaptation discussed in PR#1142
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162603163
Good idea. @nlivens please open the same patch/PR again 4.6 branch, thanks.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Posted by remibergsma <gi...@git.apache.org>.
Github user remibergsma commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162588761
@nlivens @bhaisaab If you guys want this in 4.6 as well (which seems like a good idea) please open a PR against 4.6. That will then be forward merged to master.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Posted by bhaisaab <gi...@git.apache.org>.
Github user bhaisaab commented on the pull request:
https://github.com/apache/cloudstack/pull/1185#issuecomment-162578278
Great thanks, LGTM.
cc @remibergsma - let's merge this, just so to have less Travis failures? (possibly also merge on 4.6?)
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] cloudstack pull request: Adapted HypervisorUtilsTest to no longer ...
Posted by asfgit <gi...@git.apache.org>.
Github user asfgit closed the pull request at:
https://github.com/apache/cloudstack/pull/1185
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---