[GitHub] [lucene-solr] andyvuong opened a new pull request #1029: SOLR-13101: Address flakiness of tests using async pulls and handle i…

[GitBox <gi...@apache.org>]

andyvuong opened a new pull request #1029: SOLR-13101: Address flakiness of tests using async pulls and handle i…
URL: https://github.com/apache/lucene-solr/pull/1029
 
 
   …nterrupt properly
   
   Summary
   - Addressing test flakiness from two issues:
     - Tests that rely on async pulls have test scaffolding that allows a custom pulling mechanisms to be injected into mini cluster nodes and countdown CDLs on pull completions. We shouldn't instantiate a new callback object on each call to getCorePullTaskCallback.
     - Interrupt exception was being swallowed and causing leaking threads 
   
   Changes
   - Refactored and moved the async test logic into SolrCloudSharedStoreTestCase. Only initiate the callback instance once and not per call
   - Don't catch InterruptedException in ZkStateReader. I opened a JIRA/PR in master for this https://github.com/apache/lucene-solr/pull/1023 but it hasn't been merged yet so including it here. We'll get it on next upgrade ideally.
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org