You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@hawq.apache.org by shivzone <gi...@git.apache.org> on 2016/04/19 23:01:25 UTC
[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...
GitHub user shivzone opened a pull request:
https://github.com/apache/incubator-hawq/pull/625
HAWQ-683. Fix param name for ProtocolData doc
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/apache/incubator-hawq HAWQ-683
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/incubator-hawq/pull/625.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #625
----
commit 9413cd1e6b58e8c606738d0bc9940c9d93f6cc6a
Author: Shivram Mani <sh...@gmail.com>
Date: 2016-04-19T17:58:53Z
HAWQ-683. Fix param name for ProtocolData doc
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...
Posted by sansanichfb <gi...@git.apache.org>.
Github user sansanichfb commented on the pull request:
https://github.com/apache/incubator-hawq/pull/625#issuecomment-212172887
Might be useful to have @version tag in each file, but do not add it manually to each class, but just substituting it on some build phase, reading current version from graddle properties, the similar way we do for PXF api version.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...
Posted by hornn <gi...@git.apache.org>.
Github user hornn commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/625#discussion_r60321148
--- Diff: pxf/README.md ---
@@ -20,7 +20,7 @@ Package Contents
================
PXF is distributed as a set of RPMs -
-
+git dif
--- End diff --
dif?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-683. Updates required for Javado...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone closed the pull request at:
https://github.com/apache/incubator-hawq/pull/625
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on the pull request:
https://github.com/apache/incubator-hawq/pull/625#issuecomment-212172407
Looks good
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...
Posted by kavinderd <gi...@git.apache.org>.
Github user kavinderd commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/625#discussion_r60330704
--- Diff: pxf/pxf-hdfs/src/main/java/org/apache/hawq/pxf/plugins/hdfs/AvroResolver.java ---
@@ -152,7 +152,7 @@ boolean isAvroFile() {
* The record can arrive from one out of two different sources: a sequence
* file or an AVRO file. If it comes from an AVRO file, then it was already
* obtained as a {@link GenericRecord} when when it was fetched from the
--- End diff --
Not related to your change but typo: "when when" should just be "when"
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...
Posted by GodenYao <gi...@git.apache.org>.
Github user GodenYao commented on the pull request:
https://github.com/apache/incubator-hawq/pull/625#issuecomment-212171990
+1
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
[GitHub] incubator-hawq pull request: HAWQ-683. Fix param name for Protocol...
Posted by shivzone <gi...@git.apache.org>.
Github user shivzone commented on a diff in the pull request:
https://github.com/apache/incubator-hawq/pull/625#discussion_r60322236
--- Diff: pxf/README.md ---
@@ -20,7 +20,7 @@ Package Contents
================
PXF is distributed as a set of RPMs -
-
+git dif
--- End diff --
my bad. removed it
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---