You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@sqoop.apache.org by Jarek Cecho <ja...@apache.org> on 2014/02/23 00:55:04 UTC
Review Request 18401: SQOOP-1290 Sqoop2: Kill Tomcat in case that Sqoop
Server fails to load
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18401/
-----------------------------------------------------------
Review request for Sqoop.
Bugs: SQOOP-1290
https://issues.apache.org/jira/browse/SQOOP-1290
Repository: sqoop-sqoop2
Description
-------
I've provided similar solution as has been applied to Oozie via OOZIE-786. On top of that I've also added ability to disable this behavior in case that user will run Sqoop in Tomcat that is also running other apps.
Diffs
-----
core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java f225fcb
server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 44aea2e
tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 73dc9c5
Diff: https://reviews.apache.org/r/18401/diff/
Testing
-------
Verified the fix on a real cluster.
Thanks,
Jarek Cecho
Re: Review Request 18401: SQOOP-1290 Sqoop2: Kill Tomcat in case that Sqoop
Server fails to load
Posted by Jarek Cecho <ja...@apache.org>.
> On Feb. 23, 2014, 9:57 p.m., Venkat Ranganathan wrote:
> > tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java, line 71
> > <https://reviews.apache.org/r/18401/diff/1/?file=501005#file501005line71>
> >
> > minor nit. Do you think it makes sense to add a one line comment saying we don't want to kill the Tomcat container in this case?
Yes that makes total sense, will update the patch in a minute.
- Jarek
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18401/#review35248
-----------------------------------------------------------
On Feb. 22, 2014, 11:55 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18401/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 11:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1290
> https://issues.apache.org/jira/browse/SQOOP-1290
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've provided similar solution as has been applied to Oozie via OOZIE-786. On top of that I've also added ability to disable this behavior in case that user will run Sqoop in Tomcat that is also running other apps.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java f225fcb
> server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 44aea2e
> tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 73dc9c5
>
> Diff: https://reviews.apache.org/r/18401/diff/
>
>
> Testing
> -------
>
> Verified the fix on a real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 18401: SQOOP-1290 Sqoop2: Kill Tomcat in case that Sqoop
Server fails to load
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18401/#review35248
-----------------------------------------------------------
tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java
<https://reviews.apache.org/r/18401/#comment65703>
minor nit. Do you think it makes sense to add a one line comment saying we don't want to kill the Tomcat container in this case?
- Venkat Ranganathan
On Feb. 22, 2014, 11:55 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18401/
> -----------------------------------------------------------
>
> (Updated Feb. 22, 2014, 11:55 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1290
> https://issues.apache.org/jira/browse/SQOOP-1290
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've provided similar solution as has been applied to Oozie via OOZIE-786. On top of that I've also added ability to disable this behavior in case that user will run Sqoop in Tomcat that is also running other apps.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java f225fcb
> server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 44aea2e
> tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 73dc9c5
>
> Diff: https://reviews.apache.org/r/18401/diff/
>
>
> Testing
> -------
>
> Verified the fix on a real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 18401: SQOOP-1290 Sqoop2: Kill Tomcat in case that Sqoop
Server fails to load
Posted by Venkat Ranganathan <n....@live.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18401/#review35312
-----------------------------------------------------------
Ship it!
Ship It!
- Venkat Ranganathan
On Feb. 24, 2014, 4:10 p.m., Jarek Cecho wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/18401/
> -----------------------------------------------------------
>
> (Updated Feb. 24, 2014, 4:10 p.m.)
>
>
> Review request for Sqoop.
>
>
> Bugs: SQOOP-1290
> https://issues.apache.org/jira/browse/SQOOP-1290
>
>
> Repository: sqoop-sqoop2
>
>
> Description
> -------
>
> I've provided similar solution as has been applied to Oozie via OOZIE-786. On top of that I've also added ability to disable this behavior in case that user will run Sqoop in Tomcat that is also running other apps.
>
>
> Diffs
> -----
>
> core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java f225fcb597fca7a80e52e71001bfea586de13a39
> server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 44aea2eccd50d1b9fab17d894a0d927eaf89f712
> tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 73dc9c5ba6ea170bc20ccbfb501b13c8dada5c02
>
> Diff: https://reviews.apache.org/r/18401/diff/
>
>
> Testing
> -------
>
> Verified the fix on a real cluster.
>
>
> Thanks,
>
> Jarek Cecho
>
>
Re: Review Request 18401: SQOOP-1290 Sqoop2: Kill Tomcat in case that Sqoop
Server fails to load
Posted by Jarek Cecho <ja...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/18401/
-----------------------------------------------------------
(Updated Feb. 24, 2014, 4:10 p.m.)
Review request for Sqoop.
Changes
-------
Added helpful comment to the ToolRunner explaining the added line.
Bugs: SQOOP-1290
https://issues.apache.org/jira/browse/SQOOP-1290
Repository: sqoop-sqoop2
Description
-------
I've provided similar solution as has been applied to Oozie via OOZIE-786. On top of that I've also added ability to disable this behavior in case that user will run Sqoop in Tomcat that is also running other apps.
Diffs (updated)
-----
core/src/main/java/org/apache/sqoop/core/ConfigurationConstants.java f225fcb597fca7a80e52e71001bfea586de13a39
server/src/main/java/org/apache/sqoop/server/ServerInitializer.java 44aea2eccd50d1b9fab17d894a0d927eaf89f712
tools/src/main/java/org/apache/sqoop/tools/ToolRunner.java 73dc9c5ba6ea170bc20ccbfb501b13c8dada5c02
Diff: https://reviews.apache.org/r/18401/diff/
Testing
-------
Verified the fix on a real cluster.
Thanks,
Jarek Cecho