[GitHub] [spark] dongjoon-hyun commented on a change in pull request #31172: [SPARK-34099][SQL] Use `recacheByPlan()` to recache v2 tables

[GitBox <gi...@apache.org>]

dongjoon-hyun commented on a change in pull request #31172:
URL: https://github.com/apache/spark/pull/31172#discussion_r556831895



##########
File path: sql/core/src/main/scala/org/apache/spark/sql/execution/datasources/v2/DataSourceV2Strategy.scala
##########
@@ -162,7 +160,7 @@ class DataSourceV2Strategy(session: SparkSession) extends Strategy with Predicat
       }
 
     case RefreshTable(r: ResolvedTable) =>
-      RefreshTableExec(r.catalog, r.identifier, invalidateCache(r, recacheTable = true)) :: Nil
+      RefreshTableExec(r.catalog, r.identifier, recacheTable(r)) :: Nil

Review comment:
       Is this correct? This looks wrong to me because we don't recache if the original table is not cached from the beginning. The new code looks like caching always.
   
   cc @sunchao 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: reviews-unsubscribe@spark.apache.org
For additional commands, e-mail: reviews-help@spark.apache.org