You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@aurora.apache.org by Zameer Manji <zm...@apache.org> on 2017/06/09 21:28:02 UTC
Review Request 59957: Remove restriction on task id length.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/
-----------------------------------------------------------
Review request for Aurora and Santhosh Kumar Shanmugham.
Bugs: AURORA-1897
https://issues.apache.org/jira/browse/AURORA-1897
Repository: aurora
Description
-------
To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
Diffs
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
Diff: https://reviews.apache.org/r/59957/diff/1/
Testing
-------
Thanks,
Zameer Manji
Re: Review Request 59957: Remove restriction on task id length.
Posted by Santhosh Kumar Shanmugham <sa...@gmail.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177517
-----------------------------------------------------------
Ship it!
Ship It!
- Santhosh Kumar Shanmugham
On June 9, 2017, 2:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 2:28 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 59957: Remove restriction on task id length.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177518
-----------------------------------------------------------
Master (73234d0) is red with this patch.
./build-support/jenkins/build.sh
:processJmhResources UP-TO-DATE
:jmhClasses
:checkstyleJmh
:jsHint
:checkstyleMain
:compileTestJava/home/jenkins/jenkins-slave/workspace/AuroraBot/src/test/java/org/apache/aurora/scheduler/thrift/aop/MockDecoratedThrift.java:38: Note: Wrote forwarder org.apache.aurora.scheduler.thrift.aop.MockDecoratedThriftForwarder
@Forward(AnnotatedAuroraAdmin.class)
^
Note: Some input files use or override a deprecated API.
Note: Recompile with -Xlint:deprecation for details.
:processTestResources
:testClasses
:checkstyleTest
:findbugsJmh
:findbugsMain
:findbugsTest
:licenseJmh UP-TO-DATE
:licenseMain UP-TO-DATE
:licenseTest UP-TO-DATE
:license UP-TO-DATE
:pmdJmh
:pmdMain
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:195: Avoid unused private fields such as 'taskIdGenerator'.
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:195: Perhaps 'taskIdGenerator' could be replaced by a local variable.
/home/jenkins/jenkins-slave/workspace/AuroraBot/src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java:889: Avoid unused method parameters such as 'task'.
:pmdMain FAILED
FAILURE: Build failed with an exception.
* What went wrong:
Execution failed for task ':pmdMain'.
> 3 PMD rule violations were found. See the report at: file:///home/jenkins/jenkins-slave/workspace/AuroraBot/dist/reports/pmd/main.html
* Try:
Run with --stacktrace option to get the stack trace. Run with --info or --debug option to get more log output.
BUILD FAILED
Total time: 3 mins 45.925 secs
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 9, 2017, 5:28 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 5:28 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/1/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 59957: Remove restriction on task id length.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177522
-----------------------------------------------------------
Master (6dc3d37) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/thermos/core/test_runner_integration.py::TestRunnerBasic::test_runner_processes_have_expected_output [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py::TestRunnerBasic::test_runner_processes_have_monotonically_increasing_timestamps [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestConcurrencyBasic::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py::TestConcurrencyBasic::test_runner_state_success [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py::TestConcurrencyBasic::test_runner_processes_separated_temporally_due_to_concurrency_limit [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestRunnerEnvironment::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py::TestRunnerEnvironment::test_runner_state_success [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py::TestRunnerEnvironment::test_runner_processes_have_expected_output [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestStandardStdout::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py::TestStandardStdout::test_log_config [31mFAILED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestStandardStderr::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py::TestStandardStderr::test_log_config [31mFAILED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestRotateUnderStdout::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py::TestRotateUnderStdout::test_log_config [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestRotateUnderStderr::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py::TestRotateUnderStderr::test_log_config [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestRotateOverStdout::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py::TestRotateOverStdout::test_log_config [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestRotateOverStderr::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py::TestRotateOverStderr::test_log_config [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestRotateDefaulted::test_runner_state_reconstruction [31mFAILED[0m
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/main.py", line 84, in wrap_session
INTERNALERROR> doit(config, session)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/main.py", line 122, in _main
INTERNALERROR> config.hook.pytest_runtestloop(session=session)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 413, in __call__
INTERNALERROR> return self._docall(methods, kwargs)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 424, in _docall
INTERNALERROR> res = mc.execute()
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 315, in execute
INTERNALERROR> res = method(**kwargs)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/main.py", line 142, in pytest_runtestloop
INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4
FAILURE
22:59:03 01:39 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 9, 2017, 10:14 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 10:14 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 59957: Remove restriction on task id length.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177520
-----------------------------------------------------------
Master (6dc3d37) is red with this patch.
./build-support/jenkins/build.sh
src/test/python/apache/thermos/core/test_runner_integration.py::TestConcurrencyBasic::test_runner_processes_separated_temporally_due_to_concurrency_limit [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestRunnerEnvironment::test_runner_state_reconstruction [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py::TestRunnerEnvironment::test_runner_state_success [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_integration.py::TestRunnerEnvironment::test_runner_processes_have_expected_output [32mPASSED[0m
src/test/python/apache/thermos/core/test_runner_log_config.py <- .pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/apache/thermos/testing/runner.py::TestStandardStdout::test_runner_state_reconstruction [31mFAILED[0m
INTERNALERROR> Traceback (most recent call last):
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/main.py", line 84, in wrap_session
INTERNALERROR> doit(config, session)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/main.py", line 122, in _main
INTERNALERROR> config.hook.pytest_runtestloop(session=session)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 413, in __call__
INTERNALERROR> return self._docall(methods, kwargs)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 424, in _docall
INTERNALERROR> res = mc.execute()
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 315, in execute
INTERNALERROR> res = method(**kwargs)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/main.py", line 142, in pytest_runtestloop
INTERNALERROR> item.config.hook.pytest_runtest_protocol(item=item, nextitem=nextitem)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 413, in __call__
INTERNALERROR> return self._docall(methods, kwargs)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 424, in _docall
INTERNALERROR> res = mc.execute()
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 315, in execute
INTERNALERROR> res = method(**kwargs)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest_timeout-0.5-py2.py3-none-any.whl/pytest_timeout.py", line 72, in pytest_runtest_protocol
INTERNALERROR> return __multicall__.execute()
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/core.py", line 315, in execute
INTERNALERROR> res = method(**kwargs)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/runner.py", line 65, in pytest_runtest_protocol
INTERNALERROR> runtestprotocol(item, nextitem=nextitem)
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/runner.py", line 75, in runtestprotocol
INTERNALERROR> reports.append(call_and_report(item, "call", log))
INTERNALERROR> File "/home/jenkins/jenkins-slave/workspace/AuroraBot/.pants.d/python-setup/chroots/f61bdaf7ef4564f466028ea341d2aade78412f9c/.deps/pytest-2.6.4-py2-none-any.whl/_pytest/runner.py", line 113, in call_and_report
INTERNALERROR> hook.pytest_runtest_logreport(report=report)
INTERNALERROR> File "/home/jenkin
FAILURE
22:28:51 01:08 [complete][31m
FAILURE[0m
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 9, 2017, 6:14 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 6:14 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 59957: Remove restriction on task id length.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177521
-----------------------------------------------------------
@ReviewBot retry
- Zameer Manji
On June 9, 2017, 3:14 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 3:14 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 59957: Remove restriction on task id length.
Posted by Aurora ReviewBot <wf...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177525
-----------------------------------------------------------
Ship it!
Master (6dc3d37) is green with this patch.
./build-support/jenkins/build.sh
I will refresh this build result if you post a review containing "@ReviewBot retry"
- Aurora ReviewBot
On June 9, 2017, 10:14 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 10:14 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 59957: Remove restriction on task id length.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/#review177524
-----------------------------------------------------------
@ReviewBot retry
- Zameer Manji
On June 9, 2017, 3:14 p.m., Zameer Manji wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/59957/
> -----------------------------------------------------------
>
> (Updated June 9, 2017, 3:14 p.m.)
>
>
> Review request for Aurora and Santhosh Kumar Shanmugham.
>
>
> Bugs: AURORA-1897
> https://issues.apache.org/jira/browse/AURORA-1897
>
>
> Repository: aurora
>
>
> Description
> -------
>
> To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
>
> This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
>
>
> Diffs
> -----
>
> src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
> src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
>
>
> Diff: https://reviews.apache.org/r/59957/diff/2/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Zameer Manji
>
>
Re: Review Request 59957: Remove restriction on task id length.
Posted by Zameer Manji <zm...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/59957/
-----------------------------------------------------------
(Updated June 9, 2017, 3:14 p.m.)
Review request for Aurora and Santhosh Kumar Shanmugham.
Bugs: AURORA-1897
https://issues.apache.org/jira/browse/AURORA-1897
Repository: aurora
Description
-------
To work around an old Mesos bug (MESOS-691) we would reject jobs that resulted in Mesos task ids longer than 255 characters. This is because Mesos used to use the task id to generate the cgroup path. Now Mesos uses it's own id, we no longer need to work around this bug.
This removes the restriction in the API layer. This is useful because some users may have very long role and service names that caused task ids to go over this limit.
Diffs (updated)
-----
src/main/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterface.java 059fbb86a575f5b3d78a63c9a7b5a9eebb6cb3ae
src/test/java/org/apache/aurora/scheduler/thrift/SchedulerThriftInterfaceTest.java 016859ca3bf83f64d2576b4c7109729770f9e25c
Diff: https://reviews.apache.org/r/59957/diff/2/
Changes: https://reviews.apache.org/r/59957/diff/1-2/
Testing
-------
Thanks,
Zameer Manji