You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kyuubi.apache.org by GitBox <gi...@apache.org> on 2022/01/19 14:08:00 UTC
[GitHub] [incubator-kyuubi] pan3793 opened a new pull request #1811: TPC-DS benchmark expose cli arg breakdown
pan3793 opened a new pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811
### _Why are the changes needed?_
Expose `breakdown` as cli arg in TPC-DS benchmark tool
### _How was this patch tested?_
- [ ] Add some test cases that check the changes thoroughly including negative and positive cases if possible
- [ ] Add screenshots for manual tests if appropriate
- [ ] [Run test](https://kyuubi.apache.org/docs/latest/develop_tools/testing.html#running-tests) locally before make a pull request
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on a change in pull request #1811: TPC-DS benchmark expose cli arg breakdown
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on a change in pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811#discussion_r787810419
##########
File path: dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala
##########
@@ -75,8 +78,6 @@ object RunBenchmark {
val sparkSession = SparkSession.builder.config(conf).enableHiveSupport().getOrCreate()
import sparkSession.implicits._
- sparkSession.conf.set("spark.sql.perf.results", new File("performance").toURI.toString)
Review comment:
can you leave it, since we can use client-mode
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter commented on pull request #1811: TPC-DS benchmark expose cli arg breakdown
Posted by GitBox <gi...@apache.org>.
codecov-commenter commented on pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811#issuecomment-1016534367
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1811](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bc5799) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1811 +/- ##
============================================
- Coverage 59.80% 59.80% -0.01%
Complexity 263 263
============================================
Files 274 274
Lines 13655 13655
Branches 1742 1742
============================================
- Hits 8167 8166 -1
Misses 4792 4792
- Partials 696 697 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...4bc5799](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you closed pull request #1811: TPC-DS benchmark expose cli args breakdown and results-dir
Posted by GitBox <gi...@apache.org>.
ulysses-you closed pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] codecov-commenter edited a comment on pull request #1811: TPC-DS benchmark expose cli args breakdown and results-dir
Posted by GitBox <gi...@apache.org>.
codecov-commenter edited a comment on pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811#issuecomment-1016534367
# [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) Report
> Merging [#1811](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (4bc5799) into [master](https://codecov.io/gh/apache/incubator-kyuubi/commit/e4bf6003cda11a3b75648d59872378e3e9828096?el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) (e4bf600) will **decrease** coverage by `0.00%`.
> The diff coverage is `n/a`.
> :exclamation: Current head 4bc5799 differs from pull request most recent head cc10a7e. Consider uploading reports for the commit cc10a7e to get more accurate results
[](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
```diff
@@ Coverage Diff @@
## master #1811 +/- ##
============================================
- Coverage 59.80% 59.80% -0.01%
Complexity 263 263
============================================
Files 274 274
Lines 13655 13655
Branches 1742 1742
============================================
- Hits 8167 8166 -1
Misses 4792 4792
- Partials 696 697 +1
```
| [Impacted Files](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation) | Coverage Δ | |
|---|---|---|
| [...ache/kyuubi/operation/KyuubiOperationManager.scala](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811/diff?src=pr&el=tree&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation#diff-a3l1dWJpLXNlcnZlci9zcmMvbWFpbi9zY2FsYS9vcmcvYXBhY2hlL2t5dXViaS9vcGVyYXRpb24vS3l1dWJpT3BlcmF0aW9uTWFuYWdlci5zY2FsYQ==) | `92.50% <0.00%> (-2.50%)` | :arrow_down: |
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=footer&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Last update [e4bf600...cc10a7e](https://codecov.io/gh/apache/incubator-kyuubi/pull/1811?src=pr&el=lastupdated&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=The+Apache+Software+Foundation).
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1811: TPC-DS benchmark expose cli arg breakdown
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811#discussion_r787780434
##########
File path: dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala
##########
@@ -75,8 +78,6 @@ object RunBenchmark {
val sparkSession = SparkSession.builder.config(conf).enableHiveSupport().getOrCreate()
import sparkSession.implicits._
- sparkSession.conf.set("spark.sql.perf.results", new File("performance").toURI.toString)
Review comment:
It does not make sense to write a local path when run job on yarn cluster
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] pan3793 commented on a change in pull request #1811: TPC-DS benchmark expose cli arg breakdown
Posted by GitBox <gi...@apache.org>.
pan3793 commented on a change in pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811#discussion_r803704487
##########
File path: dev/kyuubi-tpcds/src/main/scala/org/apache/kyuubi/tpcds/benchmark/RunBenchmark.scala
##########
@@ -75,8 +78,6 @@ object RunBenchmark {
val sparkSession = SparkSession.builder.config(conf).enableHiveSupport().getOrCreate()
import sparkSession.implicits._
- sparkSession.conf.set("spark.sql.perf.results", new File("performance").toURI.toString)
Review comment:
Hardcode `file://` protocol does not make sense, especially for user who run benchmark on clusters, we can set the default path without protocol.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
[GitHub] [incubator-kyuubi] ulysses-you commented on pull request #1811: TPC-DS benchmark expose cli args breakdown and results-dir
Posted by GitBox <gi...@apache.org>.
ulysses-you commented on pull request #1811:
URL: https://github.com/apache/incubator-kyuubi/pull/1811#issuecomment-1035895589
thanks, merging to master
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: commits-unsubscribe@kyuubi.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org