You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@kudu.apache.org by mp...@apache.org on 2018/09/25 21:42:27 UTC
kudu git commit: java: improve assertion failure message in
TestAsyncKuduSession.test
Repository: kudu
Updated Branches:
refs/heads/master 6030c5a32 -> 9130bb0e1
java: improve assertion failure message in TestAsyncKuduSession.test
This test is fairly flaky (tracked in KUDU-1521) and while I don't have
time to fix the underlying issue I want to make it easier to track this
in the future. Instead of just throwing a base AssertionError, it will
now throw an error indicating that it failed because it was expecting a
PleaseThrottleException that never appeared.
Change-Id: If8b2f300f34ec70ee48d81a96f378587de9f8a04
Reviewed-on: http://gerrit.cloudera.org:8080/11510
Reviewed-by: Adar Dembo <ad...@cloudera.com>
Tested-by: Mike Percy <mp...@apache.org>
Project: http://git-wip-us.apache.org/repos/asf/kudu/repo
Commit: http://git-wip-us.apache.org/repos/asf/kudu/commit/9130bb0e
Tree: http://git-wip-us.apache.org/repos/asf/kudu/tree/9130bb0e
Diff: http://git-wip-us.apache.org/repos/asf/kudu/diff/9130bb0e
Branch: refs/heads/master
Commit: 9130bb0e15d25ea8e1dfde28bebc752793100618
Parents: 6030c5a
Author: Mike Percy <mp...@apache.org>
Authored: Tue Sep 25 12:46:53 2018 -0700
Committer: Mike Percy <mp...@apache.org>
Committed: Tue Sep 25 21:42:10 2018 +0000
----------------------------------------------------------------------
.../src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
----------------------------------------------------------------------
http://git-wip-us.apache.org/repos/asf/kudu/blob/9130bb0e/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
----------------------------------------------------------------------
diff --git a/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java b/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
index 0e99254..1bf8c63 100644
--- a/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
+++ b/java/kudu-client/src/test/java/org/apache/kudu/client/TestAsyncKuduSession.java
@@ -449,7 +449,7 @@ public class TestAsyncKuduSession extends BaseKuduTest {
}
session.flush().join(DEFAULT_SLEEP);
assertEquals(20, countInRange(151, 171));
- assertTrue(gotException);
+ assertTrue("Expected PleaseThrottleException, but it was never thrown", gotException);
}
private Insert createInsert(int key) {