You are viewing a plain text version of this content. The canonical link for it is here.

Posted to notifications@skywalking.apache.org by GitBox <gi...@apache.org> on 2021/09/13 01:05:55 UTC

[GitHub] [skywalking-swck] hanahmily commented on pull request #30: add feature: java agent injector

hanahmily commented on pull request #30:
URL: https://github.com/apache/skywalking-swck/pull/30#issuecomment-917755892


   > The CI error may cause by controller-gen, the reason is the link [controller-gen error](https://github.com/kubernetes-sigs/controller-runtime/issues/780#issuecomment-713408479). For this special case, can we delete
   > `$(CONTROLLER_GEN) object:headerFile="hack/boilerplate.go.txt" paths="./apis/..." ` in ` Makefile` and `CI`?
   > I think it doesn't affect the use . Please see if it is feasible.
   
   It will insert the license header to generated APIs. If it causes these failures, we can remove it temporarily. Skywalking-eye will guarantee all headers exist. 


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: notifications-unsubscribe@skywalking.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org