You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@lucene.apache.org by GitBox <gi...@apache.org> on 2020/05/18 06:23:30 UTC
[GitHub] [lucene-solr] dsmiley opened a new pull request #1524: SOLR-XXXX: Rewrite Hash query
dsmiley opened a new pull request #1524:
URL: https://github.com/apache/lucene-solr/pull/1524
* Simpler
* Don't use Filter (to be removed)
* Do use TwoPhaseIterator, not PostFilter
* Don't pre-compute matching docs (wasteful)
* Support more fields, and more field types
* Faster hash on Strings (avoid Char conversion)
* Stronger hash when using multiple fields
----
@joel-bernstein, I set out to remove the use of Filter in `{!hash}` (because https://issues.apache.org/jira/browse/SOLR-12336 ) and then I saw a bunch of things that I felt could be improved. Apparently I had nothing better to do this weekend 😄 j/k WDYT?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1524: SOLR-15185: Rewrite Hash query
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1524:
URL: https://github.com/apache/lucene-solr/pull/1524#issuecomment-784231415
@joel-bernstein I'd like to finally get this merged. If you feel you need more time to review, LMK. I feel pretty good about it.
The the upgrade docs will mention that the computed hashes are different.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] sigram commented on pull request #1524: SOLR-15185: Rewrite Hash query
Posted by GitBox <gi...@apache.org>.
sigram commented on pull request #1524:
URL: https://github.com/apache/lucene-solr/pull/1524#issuecomment-789110063
@dsmiley the improvements Joel and I are considering are totally independent of this cleanup - please proceed with this PR.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley merged pull request #1524: SOLR-15185: Rewrite Hash query
Posted by GitBox <gi...@apache.org>.
dsmiley merged pull request #1524:
URL: https://github.com/apache/lucene-solr/pull/1524
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] dsmiley commented on pull request #1524: SOLR-15185: Rewrite Hash query
Posted by GitBox <gi...@apache.org>.
dsmiley commented on pull request #1524:
URL: https://github.com/apache/lucene-solr/pull/1524#issuecomment-788192547
No numbers. If you & @sigram are going to revamp then maybe I shouldn't merge this and you can work directly off of this PR (perhaps rebased off of master). If that's not expected for months (after 9) then I'd prefer to merge now.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] joel-bernstein commented on pull request #1524: SOLR-15185: Rewrite Hash query
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on pull request #1524:
URL: https://github.com/apache/lucene-solr/pull/1524#issuecomment-787986712
You moved quicker than I thought. Andrzej and I are also working on a revamp of this, but we can start from your PR. Feel free to commit if you're happy with your PR. We'll revisit with another ticket.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org
[GitHub] [lucene-solr] joel-bernstein commented on pull request #1524: SOLR-15185: Rewrite Hash query
Posted by GitBox <gi...@apache.org>.
joel-bernstein commented on pull request #1524:
URL: https://github.com/apache/lucene-solr/pull/1524#issuecomment-787987749
It sounds like you had some good performance improvements, do you have any performance numbers? Andrzej and I will be looking primarily performance.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@lucene.apache.org
For additional commands, e-mail: issues-help@lucene.apache.org