You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "xiangfu0 (via GitHub)" <gi...@apache.org> on 2026/06/02 00:00:30 UTC

[PR] [codex] Upgrade Jetty dependencies to 12 [pinot]

xiangfu0 opened a new pull request, #18647:
URL: https://github.com/apache/pinot/pull/18647

   ## Summary
   
   - Upgrade managed Eclipse Jetty dependencies to `12.0.35`.
   - Exclude Hadoop/Spark transitive Jetty 9-only servlet/webapp/websocket artifacts and ban Jetty versions below `12.0.35`.
   - Ban `org.apache.hadoop:hadoop-client-runtime`, which embeds relocated Jetty 9 classes.
   - Add `pinot-hadoop-shaded-xml` to provide Hadoop-compatible relocated Woodstox/StAX XML classes for Parquet without reintroducing the Hadoop runtime jar.
   - Update `LICENSE-binary` for the Jetty 12 and Woodstox/StAX dependency inventory.
   
   ## Why
   
   This removes the Jetty 9 dependency surface from Pinot's optional Hadoop/Spark/Pulsar plugin paths for CVE-2026-2332. Pinot's own HTTP stack remains Grizzly/Jersey; this is dependency hygiene for optional plugin/runtime artifacts.
   
   ## User Manual / Config Impact
   
   No Pinot table config, query syntax, or user-facing HTTP configuration changes are required. No sample table config or query changes are applicable for this dependency-only migration.
   
   ## Validation
   
   - `./mvnw -pl pinot-tools,pinot-plugins/pinot-file-system/pinot-hdfs,pinot-plugins/pinot-input-format/pinot-orc,pinot-plugins/pinot-input-format/pinot-parquet,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3,pinot-plugins/pinot-stream-ingestion/pinot-pulsar -am validate -DskipTests`
   - `./mvnw -pl pinot-plugins/pinot-input-format/pinot-hadoop-shaded-xml,pinot-plugins/pinot-input-format/pinot-parquet -am '-Dtest=Parquet*Test' -Dsurefire.failIfNoSpecifiedTests=false test`
   - `./mvnw -pl pinot-plugins/pinot-input-format/pinot-hadoop-shaded-xml,pinot-plugins/pinot-input-format/pinot-parquet -am package -DskipTests`
   - `./mvnw -pl pinot-tools,pinot-plugins/pinot-file-system/pinot-hdfs,pinot-plugins/pinot-input-format/pinot-orc,pinot-plugins/pinot-input-format/pinot-parquet,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-hadoop,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3,pinot-plugins/pinot-stream-ingestion/pinot-pulsar -am dependency:tree -Dincludes=org.eclipse.jetty,org.eclipse.jetty.websocket,org.eclipse.jetty.ee8,org.apache.hadoop:hadoop-client-runtime -DskipTests`
   - `./mvnw spotless:apply -pl pinot-bom,pinot-plugins/pinot-input-format,pinot-plugins/pinot-input-format/pinot-hadoop-shaded-xml,pinot-plugins/pinot-input-format/pinot-parquet,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3`
   - `./mvnw license:format -pl pinot-bom,pinot-plugins/pinot-input-format,pinot-plugins/pinot-input-format/pinot-hadoop-shaded-xml,pinot-plugins/pinot-input-format/pinot-parquet,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3`
   - `./mvnw checkstyle:check -pl pinot-bom,pinot-plugins/pinot-input-format,pinot-plugins/pinot-input-format/pinot-hadoop-shaded-xml,pinot-plugins/pinot-input-format/pinot-parquet,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3`
   - `./mvnw license:check -pl pinot-bom,pinot-plugins/pinot-input-format,pinot-plugins/pinot-input-format/pinot-hadoop-shaded-xml,pinot-plugins/pinot-input-format/pinot-parquet,pinot-plugins/pinot-batch-ingestion/pinot-batch-ingestion-spark-3`
   - `git diff --check`
   


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] [codex] Upgrade Jetty dependencies to 12 [pinot]

Posted by "codecov-commenter (via GitHub)" <gi...@apache.org>.
codecov-commenter commented on PR #18647:
URL: https://github.com/apache/pinot/pull/18647#issuecomment-4597923894

   ## [Codecov](https://app.codecov.io/gh/apache/pinot/pull/18647?dropdown=coverage&src=pr&el=h1&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) Report
   :white_check_mark: All modified and coverable lines are covered by tests.
   :white_check_mark: Project coverage is 56.81%. Comparing base ([`3b9a26f`](https://app.codecov.io/gh/apache/pinot/commit/3b9a26f34badee886f79c25d741436eb98fe08cf?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)) to head ([`b923c8b`](https://app.codecov.io/gh/apache/pinot/commit/b923c8b4624e2a553ebe424b5317868a6b4e8448?dropdown=coverage&el=desc&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache)).
   > :exclamation:  There is a different number of reports uploaded between BASE (3b9a26f) and HEAD (b923c8b). Click for more details.
   > 
   > <details><summary>HEAD has 16 uploads less than BASE</summary>
   >
   >| Flag | BASE (3b9a26f) | HEAD (b923c8b) |
   >|------|------|------|
   >|java-21|5|1|
   >|unittests|2|1|
   >|temurin|5|1|
   >|unittests2|1|0|
   >|integration|3|0|
   >|integration1|1|0|
   >|integration2|1|0|
   >|custom-integration1|1|0|
   ></details>
   
   <details><summary>Additional details and impacted files</summary>
   
   
   
   ```diff
   @@             Coverage Diff              @@
   ##             master   #18647      +/-   ##
   ============================================
   - Coverage     64.40%   56.81%   -7.59%     
   + Complexity     1291        1    -1290     
   ============================================
     Files          3365     2577     -788     
     Lines        208058   149638   -58420     
     Branches      32480    24178    -8302     
   ============================================
   - Hits         133992    85024   -48968     
   + Misses        63295    57424    -5871     
   + Partials      10771     7190    -3581     
   ```
   
   | [Flag](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flags&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | Coverage Δ | |
   |---|---|---|
   | [custom-integration1](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration1](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [integration2](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   | [java-21](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (-7.59%)` | :arrow_down: |
   | [temurin](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (-7.59%)` | :arrow_down: |
   | [unittests](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (-7.58%)` | :arrow_down: |
   | [unittests1](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `56.81% <ø> (+0.01%)` | :arrow_up: |
   | [unittests2](https://app.codecov.io/gh/apache/pinot/pull/18647/flags?src=pr&el=flag&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache) | `?` | |
   
   Flags with carried forward coverage won't be shown. [Click here](https://docs.codecov.io/docs/carryforward-flags?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache#carryforward-flags-in-the-pull-request-comment) to find out more.
   </details>
   
   [:umbrella: View full report in Codecov by Sentry](https://app.codecov.io/gh/apache/pinot/pull/18647?dropdown=coverage&src=pr&el=continue&utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).   
   :loudspeaker: Have feedback on the report? [Share it here](https://about.codecov.io/codecov-pr-comment-feedback/?utm_medium=referral&utm_source=github&utm_content=comment&utm_campaign=pr+comments&utm_term=apache).
   <details><summary> :rocket: New features to boost your workflow: </summary>
   
   - :package: [JS Bundle Analysis](https://docs.codecov.com/docs/javascript-bundle-analysis): Save yourself from yourself by tracking and limiting bundle sizes in JS merges.
   </details>


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Re: [PR] [codex] Upgrade Jetty dependencies to 12 [pinot]

Posted by "xiangfu0 (via GitHub)" <gi...@apache.org>.
xiangfu0 closed pull request #18647: [codex] Upgrade Jetty dependencies to 12
URL: https://github.com/apache/pinot/pull/18647


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org