You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@impala.apache.org by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org> on 2022/07/27 00:59:23 UTC
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Wenzhe Zhou has uploaded this change for review. ( http://gerrit.cloudera.org:8080/18789
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
IMPALA-11447 added the new test case
test_complex_types_result_caching, which use parquet format.
But the patch of IMPALA-9496 (Allow struct type in the select
list for Parquet tables) is not available on some other
branches.
For consistency, changed the test to use ORC format.
Testing:
- Ran the unit test for upstream and other branches.
Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
---
M tests/hs2/test_fetch_first.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/18789/1
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newchange
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
Patch Set 2:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11042/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 04:15:04 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
Patch Set 1:
(2 comments)
http://gerrit.cloudera.org:8080/#/c/18789/1/tests/hs2/test_fetch_first.py
File tests/hs2/test_fetch_first.py:
http://gerrit.cloudera.org:8080/#/c/18789/1/tests/hs2/test_fetch_first.py@471
PS1, Line 471: "
flake8: E126 continuation line over-indented for hanging indent
http://gerrit.cloudera.org:8080/#/c/18789/1/tests/hs2/test_fetch_first.py@474
PS1, Line 474: "
flake8: E126 continuation line over-indented for hanging indent
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 01:00:19 +0000
Gerrit-HasComments: Yes
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
Patch Set 2: Verified+1
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 22:14:27 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Gabor Kaszab (Code Review)" <ge...@cloudera.org>.
Gabor Kaszab has posted comments on this change. ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
Patch Set 2:
I don't think that we should have this patch upstream due to some missing commits in one of Cloudera's downstream branches.
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Thu, 28 Jul 2022 08:55:41 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
Patch Set 2:
Build started: https://jenkins.impala.io/job/gerrit-verify-dryrun/8371/ DRY_RUN=true
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 17:06:40 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Impala Public Jenkins (Code Review)" <ge...@cloudera.org>.
Impala Public Jenkins has posted comments on this change. ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
Patch Set 1:
Build Successful
https://jenkins.impala.io/job/gerrit-code-review-checks/11041/ : Initial code review checks passed. Use gerrit-verify-dryrun-external or gerrit-verify-dryrun to run full precommit tests.
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 1
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Comment-Date: Wed, 27 Jul 2022 01:26:06 +0000
Gerrit-HasComments: No
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has uploaded a new patch set (#2). ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
IMPALA-11447 added the new test case
test_complex_types_result_caching, which use parquet format.
But the patch of IMPALA-9496 (Allow struct type in the select
list for Parquet tables) is not available on some other
branches.
For consistency, changed the test to use ORC format.
Testing:
- Ran the unit test for upstream and other branches.
Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
---
M tests/hs2/test_fetch_first.py
1 file changed, 2 insertions(+), 2 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/Impala-ASF refs/changes/89/18789/2
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: newpatchset
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>
[Impala-ASF-CR] IMPALA-11447 (part 2): Fixed test failure for test complex types result caching
Posted by "Wenzhe Zhou (Code Review)" <ge...@cloudera.org>.
Wenzhe Zhou has abandoned this change. ( http://gerrit.cloudera.org:8080/18789 )
Change subject: IMPALA-11447 (part 2): Fixed test failure for test_complex_types_result_caching
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/18789
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: Impala-ASF
Gerrit-Branch: master
Gerrit-MessageType: abandon
Gerrit-Change-Id: I3d47611edae4e8589a3567d67de72ff9e69c7296
Gerrit-Change-Number: 18789
Gerrit-PatchSet: 2
Gerrit-Owner: Wenzhe Zhou <wz...@cloudera.com>
Gerrit-Reviewer: Csaba Ringhofer <cs...@cloudera.com>
Gerrit-Reviewer: Gabor Kaszab <ga...@cloudera.com>
Gerrit-Reviewer: Impala Public Jenkins <im...@cloudera.com>
Gerrit-Reviewer: Riza Suminto <ri...@cloudera.com>
Gerrit-Reviewer: Wenzhe Zhou <wz...@cloudera.com>