[GitHub] [opennlp-sandbox] kinow commented on a diff in pull request #99: Remove copy of PorterStemmer from summarizer component (DRY)

["kinow (via GitHub)" <gi...@apache.org>]

kinow commented on code in PR #99:
URL: https://github.com/apache/opennlp-sandbox/pull/99#discussion_r1167968200


##########
summarizer/src/main/java/opennlp/summarization/meta/MetaSummarizer.java:
##########
@@ -115,12 +115,10 @@ public List<Score> rankSentences(String article, List<Sentence> sent, int maxWor
   }
 
   //Default Summarization using only lexical chains..
-  public String summarize(String article, int maxWords)
-  {
+  public String summarize(String article, int maxWords) {
     //Build lexical Chains..
     List<Sentence> sent = dp.getSentencesFromStr(article);
-
-    List<Score>finalSc = rankSentences(article, sent, maxWords);
+    List<Score> finalSc = rankSentences(article, sent, maxWords);

Review Comment:
   Huh, that was probably not even compiling, right? I guess this part of the sandbox is not being tested yet?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: dev-unsubscribe@opennlp.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org