You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@ranger.apache.org by Abhay Kulkarni <ak...@hortonworks.com> on 2021/08/14 18:59:51 UTC
Review Request 73517: RANGER-3371: Update algorithm to build Ranger
policy-database object from Ranger policy-view object
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73517/
-----------------------------------------------------------
Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
Bugs: RANGER-3371
https://issues.apache.org/jira/browse/RANGER-3371
Repository: ranger
Description
-------
The algorithm to build Ranger policy database object from the Ranger policy view object leaves some fields (guid, policy-type, etc.) un-initialized during policy creation. Values of all fields whose values are known when database policy object was created need to be initialized so that the policy_text field-value can be used to recreate the original policy.
Also, Ranger admin log contains many spurious messages which incorrectly indicate error conditions. Ranger admin is updated to avoid logging such messages.
Diffs
-----
agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java f040a66f1
security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java c5add3aa2
security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java 04aa4720f
security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java fc44e6dce
security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 047228bbc
security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java e8c593dc1
Diff: https://reviews.apache.org/r/73517/diff/1/
Testing
-------
Passed all unit tests.
Tested in a private cluster to ensure that the x_policy table rows are updated with values that were not filled in earlier.
Thanks,
Abhay Kulkarni
Re: Review Request 73517: RANGER-3371: Update algorithm to build
Ranger policy-database object from Ranger policy-view object
Posted by Ramesh Mani <rm...@hortonworks.com>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73517/#review223341
-----------------------------------------------------------
Ship it!
Ship It!
- Ramesh Mani
On Aug. 14, 2021, 6:59 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73517/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2021, 6:59 p.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3371
> https://issues.apache.org/jira/browse/RANGER-3371
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The algorithm to build Ranger policy database object from the Ranger policy view object leaves some fields (guid, policy-type, etc.) un-initialized during policy creation. Values of all fields whose values are known when database policy object was created need to be initialized so that the policy_text field-value can be used to recreate the original policy.
>
> Also, Ranger admin log contains many spurious messages which incorrectly indicate error conditions. Ranger admin is updated to avoid logging such messages.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java f040a66f1
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java c5add3aa2
> security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java 04aa4720f
> security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java fc44e6dce
> security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 047228bbc
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java e8c593dc1
>
>
> Diff: https://reviews.apache.org/r/73517/diff/1/
>
>
> Testing
> -------
>
> Passed all unit tests.
> Tested in a private cluster to ensure that the x_policy table rows are updated with values that were not filled in earlier.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>
Re: Review Request 73517: RANGER-3371: Update algorithm to build
Ranger policy-database object from Ranger policy-view object
Posted by Madhan Neethiraj <ma...@apache.org>.
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/73517/#review223340
-----------------------------------------------------------
Ship it!
Ship It!
- Madhan Neethiraj
On Aug. 14, 2021, 6:59 p.m., Abhay Kulkarni wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://reviews.apache.org/r/73517/
> -----------------------------------------------------------
>
> (Updated Aug. 14, 2021, 6:59 p.m.)
>
>
> Review request for ranger, Dineshkumar Yadav, Madhan Neethiraj, Mehul Parikh, Ramesh Mani, Sailaja Polavarapu, and Velmurugan Periasamy.
>
>
> Bugs: RANGER-3371
> https://issues.apache.org/jira/browse/RANGER-3371
>
>
> Repository: ranger
>
>
> Description
> -------
>
> The algorithm to build Ranger policy database object from the Ranger policy view object leaves some fields (guid, policy-type, etc.) un-initialized during policy creation. Values of all fields whose values are known when database policy object was created need to be initialized so that the policy_text field-value can be used to recreate the original policy.
>
> Also, Ranger admin log contains many spurious messages which incorrectly indicate error conditions. Ranger admin is updated to avoid logging such messages.
>
>
> Diffs
> -----
>
> agents-common/src/main/java/org/apache/ranger/plugin/util/RangerPolicyDeltaUtil.java f040a66f1
> security-admin/src/main/java/org/apache/ranger/biz/ServiceDBStore.java c5add3aa2
> security-admin/src/main/java/org/apache/ranger/common/RangerServicePoliciesCache.java 04aa4720f
> security-admin/src/main/java/org/apache/ranger/common/db/RangerTransactionSynchronizationAdapter.java fc44e6dce
> security-admin/src/main/java/org/apache/ranger/db/XXPolicyChangeLogDao.java 047228bbc
> security-admin/src/main/java/org/apache/ranger/service/RangerPolicyServiceBase.java e8c593dc1
>
>
> Diff: https://reviews.apache.org/r/73517/diff/1/
>
>
> Testing
> -------
>
> Passed all unit tests.
> Tested in a private cluster to ensure that the x_policy table rows are updated with values that were not filled in earlier.
>
>
> Thanks,
>
> Abhay Kulkarni
>
>