[GitHub] [skywalking] wu-sheng commented on a change in pull request #4843: Support UI template management.

[GitBox <gi...@apache.org>]

wu-sheng commented on a change in pull request #4843:
URL: https://github.com/apache/skywalking/pull/4843#discussion_r433045784



##########
File path: test/e2e/e2e-test/src/test/java/org/apache/skywalking/e2e/storage/StorageE2E.java
##########
@@ -156,6 +167,54 @@ void serviceInstanceTopo() throws Exception {
         verifyServiceInstanceRelationMetrics(topology.getCalls());
     }
 
+    @RetryableTest
+    void addUITemplate() throws Exception {
+        try {
+            TemplateChangeStatus templateChangeStatus = graphql.addTemplate(
+                new DashboardSetting()
+                    .name("test-ui-config-1")
+                    .active(true)
+                    .configuration("{}")
+                    .type(TemplateType.DASHBOARD)
+            );
+            LOGGER.info("add template = {}", templateChangeStatus);
+        } catch (Exception e) {
+            LOGGER.error("add ui template error.", e);
+        }
+        verifyTemplates("expected/storage/dashboardConfiguration.yml");
+    }
+
+    @RetryableTest
+    void changeTemplate() throws Exception {

Review comment:
       I don't want to discuss about the language culture thing, as these two words are not that different. You could argue about add, insert or create too. As creating is a part of CRUD. 
   
   The point is, unless we want to set up term rules in order to keep all names consistent in the project, don't know how to say which one is better.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org