You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/15 03:18:58 UTC

[GitHub] [hadoop-ozone] smengcl opened a new pull request #822: HDDS-3390. Rebase OFS branch - 2

smengcl opened a new pull request #822: HDDS-3390. Rebase OFS branch - 2
URL: https://github.com/apache/hadoop-ozone/pull/822
 
 
   ## What changes were proposed in this pull request?
   
   1. Rebase OFS dev branch
   2. Fix OFSPath: https://github.com/apache/hadoop-ozone/commit/9b47210e67816763a68f59406f0d96c8b8083065
   - HDDS-3353 broke OFSPath since the latter uses org.apache.commons.codec.digest.DigestUtils but the dependency is removed.
   - HDDS-3359 broke OFSPath because the latter also uses org.apache.yetus.audience, but this is a simple fix - just replace it with org.apache.hadoop.hdds.annotation.
   
   ## What is the link to the Apache JIRA
   
   https://issues.apache.org/jira/browse/HDDS-3390
   
   ## How was this patch tested?
   
   This PR itself is only for triggering tests and commenting.
   Will commit manually via command line.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #822: HDDS-3390. Rebase OFS branch - 2

Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #822: HDDS-3390. Rebase OFS branch - 2
URL: https://github.com/apache/hadoop-ozone/pull/822#discussion_r410779124
 
 

 ##########
 File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OFSPath.java
 ##########
 @@ -186,6 +189,21 @@ public boolean isVolume() {
     return this.getBucketName().isEmpty() && !this.getVolumeName().isEmpty();
   }
 
+  private static String md5Hex(String input) {
+    try {
+      MessageDigest md = MessageDigest.getInstance("MD5");
+      byte[] digest = md.digest(input.getBytes());
 
 Review comment:
   Added parameter `StandardCharsets.UTF_8` to `getBytes()`. Shouldn't complain now.
   
   Note: Force pushed to make the extra change into only one extra commit. Easier for manual cherry-picking later. 

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org

[GitHub] [hadoop-ozone] smengcl commented on a change in pull request #822: HDDS-3390. Rebase OFS branch - 2

Posted by GitBox <gi...@apache.org>.
smengcl commented on a change in pull request #822: HDDS-3390. Rebase OFS branch - 2
URL: https://github.com/apache/hadoop-ozone/pull/822#discussion_r410773493
 
 

 ##########
 File path: hadoop-ozone/ozonefs/src/main/java/org/apache/hadoop/fs/ozone/OFSPath.java
 ##########
 @@ -186,6 +189,21 @@ public boolean isVolume() {
     return this.getBucketName().isEmpty() && !this.getVolumeName().isEmpty();
   }
 
+  private static String md5Hex(String input) {
+    try {
+      MessageDigest md = MessageDigest.getInstance("MD5");
+      byte[] digest = md.digest(input.getBytes());
 
 Review comment:
   I have implemented my own md5sum in OFSPath, but the check (findbugs) doesn't like it:
   ```
   Found reliance on default encoding in org.apache.hadoop.fs.ozone.OFSPath.md5Hex(String): String.getBytes()  At OFSPath.java:[line 195]
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org