You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@mxnet.apache.org by GitBox <gi...@apache.org> on 2021/04/07 22:07:18 UTC

[GitHub] [incubator-mxnet] anko-intel commented on a change in pull request #20107: [v1.x][BUGFIX] Implement oneDNN deconvolution primitives to deconvolution 2D

anko-intel commented on a change in pull request #20107:
URL: https://github.com/apache/incubator-mxnet/pull/20107#discussion_r609100865



##########
File path: tests/python/mkl/test_mkldnn.py
##########
@@ -469,10 +469,9 @@ def check_convolution_training(stype):
 
 
 @with_seed()
-@unittest.skip("Flaky test https://github.com/apache/incubator-mxnet/issues/12579")
 def test_Deconvolution():
     def check_Deconvolution_training(stype):
-        for shape in [(3, 3, 10), (3, 3, 10, 10)]:
+        for shape in [(3, 3, 10, 10)]: # testing only 2D for now

Review comment:
       "for now" is ok for now ;-), as I assume 3D test will be reintroduced soon. But usually "for now" means nothing to the comment reader and should be replaced with something more specific.
   




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org