You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@cordova.apache.org by dreifachstein <gi...@git.apache.org> on 2017/06/11 09:55:33 UTC
[GitHub] cordova-android pull request #385: CB-12835: add a Context getter in Cordova...
GitHub user dreifachstein opened a pull request:
https://github.com/apache/cordova-android/pull/385
CB-12835: add a Context getter in CordovaInterface
A custom engine may live outside of the Activity's lifecycle and the
Activity instance may not always be available. This getter allows
Context accesses in all cases.
You can merge this pull request into a Git repository by running:
$ git pull https://github.com/dreifachstein/cordova-android master
Alternatively you can review and apply these changes as the patch at:
https://github.com/apache/cordova-android/pull/385.patch
To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:
This closes #385
----
commit 17906735dfe23e74cbe75394a0de3bf448233f25
Author: Xiaolei Yu <dr...@gmail.com>
Date: 2017-05-19T22:54:23Z
CB-12835: add a Context getter in CordovaInterface
A custom engine may live outside of the Activity's lifecycle and the
Activity instance may not always be available. This getter allows
Context accesses in all cases.
----
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #385: CB-12835: add a Context getter in CordovaInterfa...
Posted by infil00p <gi...@git.apache.org>.
Github user infil00p commented on the issue:
https://github.com/apache/cordova-android/pull/385
@filmaj Yeah, that definitely needs an update.
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #385: CB-12835: add a Context getter in CordovaInterfa...
Posted by filmaj <gi...@git.apache.org>.
Github user filmaj commented on the issue:
https://github.com/apache/cordova-android/pull/385
Does anything need to change in the plugin authoring documentation for Android as a result of this?
https://cordova.apache.org/docs/en/latest/guide/platforms/android/plugin.html
Maybe the Android Integration section needs updating? It references that the context is no longer available?
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org
[GitHub] cordova-android issue #385: CB-12835: add a Context getter in CordovaInterfa...
Posted by codecov-io <gi...@git.apache.org>.
Github user codecov-io commented on the issue:
https://github.com/apache/cordova-android/pull/385
# [Codecov](https://codecov.io/gh/apache/cordova-android/pull/385?src=pr&el=h1) Report
> Merging [#385](https://codecov.io/gh/apache/cordova-android/pull/385?src=pr&el=desc) into [master](https://codecov.io/gh/apache/cordova-android/commit/3a6e898b12eac31dfc16a4c526dfba8fab158723?src=pr&el=desc) will **not change** coverage.
> The diff coverage is `n/a`.
[](https://codecov.io/gh/apache/cordova-android/pull/385?src=pr&el=tree)
```diff
@@ Coverage Diff @@
## master #385 +/- ##
=======================================
Coverage 39.52% 39.52%
=======================================
Files 16 16
Lines 1551 1551
Branches 277 277
=======================================
Hits 613 613
Misses 938 938
```
------
[Continue to review full report at Codecov](https://codecov.io/gh/apache/cordova-android/pull/385?src=pr&el=continue).
> **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
> `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
> Powered by [Codecov](https://codecov.io/gh/apache/cordova-android/pull/385?src=pr&el=footer). Last update [3a6e898...1790673](https://codecov.io/gh/apache/cordova-android/pull/385?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
---
If your project is set up for it, you can reply to this email and have your
reply appear on GitHub as well. If your project does not have this feature
enabled and wishes so, or if the feature is enabled but not working, please
contact infrastructure at infrastructure@apache.org or file a JIRA ticket
with INFRA.
---
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@cordova.apache.org
For additional commands, e-mail: dev-help@cordova.apache.org