You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@river.apache.org by "Brian Murphy (JIRA)" <ji...@apache.org> on 2008/05/22 01:19:57 UTC

[jira] Resolved: (RIVER-291) Cannot build QA tests using the supplied make files

     [ https://issues.apache.org/jira/browse/RIVER-291?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Brian Murphy resolved RIVER-291.
--------------------------------

    Resolution: Fixed

Manually tested on ubuntu 2.6.17
Built the River source and jars
Built the QA tests source and jars 
Ran executed the tests according to the instructions in 
the newly added file, <svn>/qatests/trunk/qatestsREADME.txt

btm-21-May-2008


> Cannot build QA tests using the supplied make files
> ---------------------------------------------------
>
>                 Key: RIVER-291
>                 URL: https://issues.apache.org/jira/browse/RIVER-291
>             Project: River
>          Issue Type: Test
>          Components: build
>    Affects Versions: AR1
>         Environment: unix or linux based systems with access to the GNU make utility
>            Reporter: Brian Murphy
>            Assignee: Brian Murphy
>             Fix For: AR2
>
>         Attachments: qatestsBuildFix.diff
>
>
> Originally, the QA tests and associated framework (harness) 
> that were created to test the Jini source were developed, managed,
> and run internally. Because of this, the original GNU make files 
> used to build the tests were never converted to Ant scripts (unlike 
> what was eventually done for the Jini source code itself). 
> When the QA framework and the tests that are run by that framework 
> was eventually distributed, the internal make files for those tests were 
> also distributed; but only as examples of what one might need to do to 
> build the framework and tests. At the time, there was not an expectation
> that active development of the tests would occur outside of the Jini
> team.
> Now that the Jini QA tests and framework have become part of the
> River project, it seems desirable to make the appropriate modifications
> to the various GNU make files and other related files to allow one to
> build and run the tests against the Jini services and utilities of the 
> River Project. 
> Although one might argue that it would be more desirable to convert 
> the QA make files to Ant scripts that perform the same function, it
> seems like fixing the make files might be a good first step in that
> direction; given that the creation of the Ant scripts will probably 
> involve quite a bit more work than modifying the make files. At the 
> very least, fixing the make files now, rather than waiting for the Ant
> scripts to be created, should allow River developers to run a significant 
> number of existing regression tests without having to write duplicate 
> tests, or create a new test framework.
> In addition to modifying the make files and other related tests, as
> part of this issue, it would be desirable to provide a short "README"
> file that describes the steps one would take not only to build the
> QA tests, but also the steps one would take to run the tests.
> btm-20-May-2008

-- 
This message is automatically generated by JIRA.
-
You can reply to this email to add a comment to the issue online.


Re: Cannot build QA tests using the supplied make files

Posted by Nigel Daley <nd...@mac.com>.
Brian, thanks for this fix and the README!

I've now setup Hudson to build the qatests and run a category of  
tests (joinmanager) which takes about 1 hour.  We should really come  
up with a category of smoke tests that can be run with each checkin  
by Hudson.  In the meantime feel free to suggest a different existing  
category of tests.

Also, I've switch Hudson to be true CI for River.  It will now check  
for SVN changes every 15 minutes and build/test if there are changes.

http://hudson.zones.apache.org/hudson/job/River-trunk/

Cheers,
Nige

On May 21, 2008, at 4:19 PM, Brian Murphy (JIRA) wrote:
>
>      [ https://issues.apache.org/jira/browse/RIVER-291? 
> page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]
>
> Brian Murphy resolved RIVER-291.
> --------------------------------
>
>     Resolution: Fixed
>
> Manually tested on ubuntu 2.6.17
> Built the River source and jars
> Built the QA tests source and jars
> Ran executed the tests according to the instructions in
> the newly added file, <svn>/qatests/trunk/qatestsREADME.txt
>
> btm-21-May-2008
>
>
>> Cannot build QA tests using the supplied make files
>> ---------------------------------------------------
>>
>>                 Key: RIVER-291
>>                 URL: https://issues.apache.org/jira/browse/RIVER-291
>>             Project: River
>>          Issue Type: Test
>>          Components: build
>>    Affects Versions: AR1
>>         Environment: unix or linux based systems with access to  
>> the GNU make utility
>>            Reporter: Brian Murphy
>>            Assignee: Brian Murphy
>>             Fix For: AR2
>>
>>         Attachments: qatestsBuildFix.diff
>>
>>
>> Originally, the QA tests and associated framework (harness)
>> that were created to test the Jini source were developed, managed,
>> and run internally. Because of this, the original GNU make files
>> used to build the tests were never converted to Ant scripts (unlike
>> what was eventually done for the Jini source code itself).
>> When the QA framework and the tests that are run by that framework
>> was eventually distributed, the internal make files for those  
>> tests were
>> also distributed; but only as examples of what one might need to  
>> do to
>> build the framework and tests. At the time, there was not an  
>> expectation
>> that active development of the tests would occur outside of the Jini
>> team.
>> Now that the Jini QA tests and framework have become part of the
>> River project, it seems desirable to make the appropriate  
>> modifications
>> to the various GNU make files and other related files to allow one to
>> build and run the tests against the Jini services and utilities of  
>> the
>> River Project.
>> Although one might argue that it would be more desirable to convert
>> the QA make files to Ant scripts that perform the same function, it
>> seems like fixing the make files might be a good first step in that
>> direction; given that the creation of the Ant scripts will probably
>> involve quite a bit more work than modifying the make files. At the
>> very least, fixing the make files now, rather than waiting for the  
>> Ant
>> scripts to be created, should allow River developers to run a  
>> significant
>> number of existing regression tests without having to write duplicate
>> tests, or create a new test framework.
>> In addition to modifying the make files and other related tests, as
>> part of this issue, it would be desirable to provide a short "README"
>> file that describes the steps one would take not only to build the
>> QA tests, but also the steps one would take to run the tests.
>> btm-20-May-2008
>
> -- 
> This message is automatically generated by JIRA.
> -
> You can reply to this email to add a comment to the issue online.
>