You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@pinot.apache.org by "Jackie-Jiang (via GitHub)" <gi...@apache.org> on 2023/07/20 01:17:52 UTC

[GitHub] [pinot] Jackie-Jiang commented on pull request #10815: Periodically delete Tmp Segment file brought by the SplitCommit End phase

Jackie-Jiang commented on PR #10815:
URL: https://github.com/apache/pinot/pull/10815#issuecomment-1642964875

   What I meant is to always enable this periodic task and remove the sync cleanup logic.
   Adding a dedicated periodic task per specific job is more modular, but we also need to consider if it can cause problem when running in parallel with another periodic task (e.g. we had encountered some problems when 2 periodic task working on the same table at the same time). I feel this clean up logic can be fit into the existing `RealtimeSegmentValidationManager`


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org