[GitHub] [nifi] mattyb149 commented on issue #3554: NIFI-5417: Add missing component status and metrics to S2SStatusReportingTask and PrometheusReportingTask

[GitBox <gi...@apache.org>]

mattyb149 commented on issue #3554: NIFI-5417: Add missing component status and metrics to S2SStatusReportingTask and PrometheusReportingTask
URL: https://github.com/apache/nifi/pull/3554#issuecomment-505993526
 
 
   No [NIFI-6352](https://issues.apache.org/jira/browse/NIFI-6352) did that, this just extended from the fact that things like "terminated thread count" are available but aren't being reported by the ReportingTasks that are responsible for it.
   
   I'll be writing a follow-on for the PrometheusReportingTask so we don't register the Gauges we don't need. They're all static members on the class and are all registered, even if we don't pick "All Components" as the strategy. I should've done it under NIFI-6352 but I didn't notice until after it went in. If I can get it changed before 1.10 I'll reopen the Jira and do the work under that.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services