You are viewing a plain text version of this content. The canonical link for it is here.

Posted to jira@kafka.apache.org by GitBox <gi...@apache.org> on 2021/03/16 21:36:09 UTC

[GitHub] [kafka] yatsukav commented on a change in pull request #10333: KAFKA-12481: Add socket.nagle.disable config property

yatsukav commented on a change in pull request #10333:
URL: https://github.com/apache/kafka/pull/10333#discussion_r595557313



##########
File path: core/src/main/scala/kafka/server/KafkaConfig.scala
##########
@@ -391,6 +392,7 @@ object KafkaConfig {
   val AdvertisedListenersProp = "advertised.listeners"
   val ListenerSecurityProtocolMapProp = "listener.security.protocol.map"
   val ControlPlaneListenerNameProp = "control.plane.listener.name"
+  val SocketNagleDisableProp = "socket.nagle.disable"

Review comment:
       I take `socket.nagle.disable` from librdkafka project. But ok, I rename it to `socket.tcp.no.delay`. Perhaps this is clearer.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org