You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@iotdb.apache.org by GitBox <gi...@apache.org> on 2021/11/17 03:00:26 UTC

[GitHub] [iotdb] SteveYurongSu commented on a change in pull request #4411: [IOTDB-2022]SessionDataSet implements AutoCloseable

SteveYurongSu commented on a change in pull request #4411:
URL: https://github.com/apache/iotdb/pull/4411#discussion_r750845475



##########
File path: session/src/main/java/org/apache/iotdb/session/SessionDataSet.java
##########
@@ -196,6 +196,15 @@ public DataIterator iterator() {
     return new DataIterator();
   }
 
+  @Override
+  public void close() throws IoTDBConnectionException, StatementExecutionException {
+    try {
+      ioTDBRpcDataSet.close();
+    } catch (TException e) {
+      throw new IoTDBConnectionException(e.getMessage());
+    }

Review comment:
       ```suggestion
       closeOperationHandle()
   ```




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: reviews-unsubscribe@iotdb.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org