You are viewing a plain text version of this content. The canonical link for it is here.
Posted to issues@ozone.apache.org by GitBox <gi...@apache.org> on 2020/04/01 15:03:37 UTC
[GitHub] [hadoop-ozone] elek opened a new pull request #748: HDDS-3318.
Support /close command in the Github comments
elek opened a new pull request #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748
## What changes were proposed in this pull request?
As it's discussed during the last community meeting we can close pending pull requests after 30 days. /close command can make it easier.
We can also add pending label to the pending pull requests.
## What is the link to the Apache JIRA
https://issues.apache.org/jira/browse/HDDS-3318
## How was this patch tested?
On my personal fork. But I will try to test it on this pr.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#748: HDDS-3318. Support /close command in the Github comments
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#discussion_r401704076
##########
File path: .github/comment-commands/close.sh
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#doc: Close pending pull request temporary
+# shellcheck disable=SC2124
+MESSAGE="Thank you very much the patch. I am closing this issue __temporary__ as there was no
+activity recently and it's pending on the author of the PR.
+
+It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
+
+It means only that attention of commiters is not required. To get faster review for all the PRs,
+we prefer to clean the queue to show which PRs require review or feedback.
Review comment:
```suggestion
It only means that attention of committers is not required. We prefer to keep the review queue clean. This ensures PRs in need of review are more visible, which results in faster feedback for all PRs.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #748: HDDS-3318. Support
/close command in the Github comments
Posted by GitBox <gi...@apache.org>.
elek commented on issue #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#issuecomment-607307473
> But I will try to test it on this pr.
It's not working. But it's tested on this PR:
https://github.com/elek/hadoop-ozone/pull/10
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #748:
HDDS-3318. Support /close command in the Github comments
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#discussion_r402289553
##########
File path: .github/comment-commands/close.sh
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#doc: Close pending pull request temporary
+# shellcheck disable=SC2124
+MESSAGE="Thank you very much the patch. I am closing this issue __temporary__ as there was no
+activity recently and it's pending on the author of the PR.
+
+It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
+
+It means only that attention of commiters is not required. To get faster review for all the PRs,
+we prefer to clean the queue to show which PRs require review or feedback.
Review comment:
typo fixes 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #748: HDDS-3318. Support
/close command in the Github comments
Posted by GitBox <gi...@apache.org>.
elek commented on issue #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#issuecomment-608398444
Thanks the review @adoroszlai (fixing my language mistakes are always a big help for me), I am merging it to the trunk.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#748: HDDS-3318. Support /close command in the Github comments
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#discussion_r401706397
##########
File path: .github/comment-commands/close.sh
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#doc: Close pending pull request temporary
+# shellcheck disable=SC2124
+MESSAGE="Thank you very much the patch. I am closing this issue __temporary__ as there was no
+activity recently and it's pending on the author of the PR.
+
+It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
+
+It means only that attention of commiters is not required. To get faster review for all the PRs,
+we prefer to clean the queue to show which PRs require review or feedback.
+
+If you need ANY help to finish this PR, please contact with the community on the mailing list or the slack channel.
+
+(See the README about the details of chat/mailing list: https://github.com/apache/hadoop-ozone)"
Review comment:
```suggestion
If you need ANY help to finish this PR, please [contact the community](https://github.com/apache/hadoop-ozone#contact) on the mailing list or the slack channel.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] github-actions[bot] commented on issue #748:
HDDS-3318. Support /close command in the Github comments
Posted by GitBox <gi...@apache.org>.
github-actions[bot] commented on issue #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#issuecomment-607303211
Available commands:
* /**help** : Show all the available comment commands
* /**label** : add new label to the issue: `/label <label>`
* /**pending** : Add a REQUESTED_CHANGE type review to mark issue non-mergeable: `/pending <reason>`
* /**ready** : Dismiss all the blocking reviews by github-actions bot
* /**retest** : add new empty commit to trigger new CI build
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on issue #748: HDDS-3318. Support
/close command in the Github comments
Posted by GitBox <gi...@apache.org>.
elek commented on issue #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#issuecomment-607303018
/help
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek closed pull request #748: HDDS-3318. Support
/close command in the Github comments
Posted by GitBox <gi...@apache.org>.
elek closed pull request #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] adoroszlai commented on a change in pull request
#748: HDDS-3318. Support /close command in the Github comments
Posted by GitBox <gi...@apache.org>.
adoroszlai commented on a change in pull request #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#discussion_r401698697
##########
File path: .github/comment-commands/close.sh
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#doc: Close pending pull request temporary
+# shellcheck disable=SC2124
+MESSAGE="Thank you very much the patch. I am closing this issue __temporary__ as there was no
+activity recently and it's pending on the author of the PR.
Review comment:
```suggestion
MESSAGE="Thank you very much for the patch. I am closing this PR __temporarily__ as there was no
activity recently and it is waiting for response from its author.
```
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org
[GitHub] [hadoop-ozone] elek commented on a change in pull request #748:
HDDS-3318. Support /close command in the Github comments
Posted by GitBox <gi...@apache.org>.
elek commented on a change in pull request #748: HDDS-3318. Support /close command in the Github comments
URL: https://github.com/apache/hadoop-ozone/pull/748#discussion_r402289553
##########
File path: .github/comment-commands/close.sh
##########
@@ -0,0 +1,44 @@
+#!/usr/bin/env bash
+# Licensed to the Apache Software Foundation (ASF) under one or more
+# contributor license agreements. See the NOTICE file distributed with
+# this work for additional information regarding copyright ownership.
+# The ASF licenses this file to You under the Apache License, Version 2.0
+# (the "License"); you may not use this file except in compliance with
+# the License. You may obtain a copy of the License at
+#
+# http://www.apache.org/licenses/LICENSE-2.0
+#
+# Unless required by applicable law or agreed to in writing, software
+# distributed under the License is distributed on an "AS IS" BASIS,
+# WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
+# See the License for the specific language governing permissions and
+# limitations under the License.
+
+#doc: Close pending pull request temporary
+# shellcheck disable=SC2124
+MESSAGE="Thank you very much the patch. I am closing this issue __temporary__ as there was no
+activity recently and it's pending on the author of the PR.
+
+It doesn't mean that this PR is not important or ignored: feel free to reopen the PR at any time.
+
+It means only that attention of commiters is not required. To get faster review for all the PRs,
+we prefer to clean the queue to show which PRs require review or feedback.
Review comment:
typo fixes 2
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: ozone-issues-unsubscribe@hadoop.apache.org
For additional commands, e-mail: ozone-issues-help@hadoop.apache.org