You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@superset.apache.org by GitBox <gi...@apache.org> on 2021/08/01 09:21:31 UTC
[GitHub] [superset] jinghua-qa opened a new issue #15997: [pivot table v2] Same metric added multiples times will show sum in pivot table v2
jinghua-qa opened a new issue #15997:
URL: https://github.com/apache/superset/issues/15997
Same metric added multiples times will show sum in pivot table v2 rather than showing multiple same metrics
### Expected results
Same metric added multiples times will show multiple same metrics
### Actual results
Same metric added multiples times will show sum
#### Screenshots
<img width="1493" alt="Screen Shot 2021-08-01 at 2 15 43 AM" src="https://user-images.githubusercontent.com/81597121/127765933-a2f60764-b1f2-44f5-ac95-a554d8398767.png">
<img width="1492" alt="Screen Shot 2021-08-01 at 2 16 31 AM" src="https://user-images.githubusercontent.com/81597121/127765936-8c937b3a-7ce5-45e1-944f-f5ce5741a8fa.png">
#### How to reproduce the bug
1. open pivot table v2 with a dataset
2. add the same metrics multiple times
3. observe the table
4. See error
### Environment
(please complete the following information):
- superset version: `master`
- python version: `python --version`
- node.js version: `node -v`
- any feature flags active:
### Checklist
Make sure to follow these steps before submitting your issue - thank you!
- [x] I have checked the superset logs for python stacktraces and included it here as text if there are any.
- [x] I have reproduced the issue with at least the latest released version of superset.
- [x] I have checked the issue tracker for the same issue and I haven't found one similar.
### Additional context
Add any other context about the problem here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje commented on issue #15997: [pivot table v2] Same metric added multiples times will show sum in pivot table v2
Posted by GitBox <gi...@apache.org>.
kgabryje commented on issue #15997:
URL: https://github.com/apache/superset/issues/15997#issuecomment-891121860
Fixed by https://github.com/apache/superset/pull/16020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje closed issue #15997: [pivot table v2] Same metric added multiples times will show sum in pivot table v2
Posted by GitBox <gi...@apache.org>.
kgabryje closed issue #15997:
URL: https://github.com/apache/superset/issues/15997
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] jinghua-qa commented on issue #15997: [pivot table v2] Same metric added multiples times will show sum in pivot table v2
Posted by GitBox <gi...@apache.org>.
jinghua-qa commented on issue #15997:
URL: https://github.com/apache/superset/issues/15997#issuecomment-890483621
@kgabryje
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] junlincc commented on issue #15997: [pivot table v2] Same metric added multiples times will show sum in pivot table v2
Posted by GitBox <gi...@apache.org>.
junlincc commented on issue #15997:
URL: https://github.com/apache/superset/issues/15997#issuecomment-890647946
i'm not sure if we should allow the same metric being added twice, i remember we have discussed this in pivot(legacy) and table before.
Thanks for QAing this is awesome!!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] mistercrunch commented on issue #15997: [pivot table v2] Same metric added multiples times will show sum in pivot table v2
Posted by GitBox <gi...@apache.org>.
mistercrunch commented on issue #15997:
URL: https://github.com/apache/superset/issues/15997#issuecomment-890700002
Solution is probably to improve `MetricControl` and add a new `allowDuplicates` prop that is `false` by default. I don't think we have any place where we need to allow duplicates. This could be categorized `P3`
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org
[GitHub] [superset] kgabryje removed a comment on issue #15997: [pivot table v2] Same metric added multiples times will show sum in pivot table v2
Posted by GitBox <gi...@apache.org>.
kgabryje removed a comment on issue #15997:
URL: https://github.com/apache/superset/issues/15997#issuecomment-891121860
Fixed by https://github.com/apache/superset/pull/16020
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org