You are viewing a plain text version of this content. The canonical link for it is here.

Posted to commits@nuttx.apache.org by GitBox <gi...@apache.org> on 2021/05/07 13:15:02 UTC

[GitHub] [incubator-nuttx] davids5 commented on a change in pull request #3669: STM32 {F7|H7} Use 250 Ms Data path timeout, regardless of Card Clock frequency

davids5 commented on a change in pull request #3669:
URL: https://github.com/apache/incubator-nuttx/pull/3669#discussion_r628200676



##########
File path: arch/arm/src/stm32/stm32_sdio.c
##########
@@ -172,9 +172,14 @@
 #define SDIO_CMDTIMEOUT          (100000)
 #define SDIO_LONGTIMEOUT         (0x7fffffff)
 
-/* Big DTIMER setting */
+/* DTIMER setting
+ *
+ * Assuming Max timeout in bypass 48 Mhz
+ *
+ */
 
-#define SDIO_DTIMER_DATATIMEOUT  (0x000fffff)
+#define IP_CLCK_FREQ 48000000ll

Review comment:
       Hmm, It is not intuitive or obvious.
   Do you object to leaving it as is in this acrh specific file?




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org