You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Wang Xixu (Code Review)" <ge...@cloudera.org> on 2023/12/07 07:55:17 UTC
[kudu-CR] [util] add a warning into 'heap sample every n bytes' flag description.
Wang Xixu has posted comments on this change. ( http://gerrit.cloudera.org:8080/20716 )
Change subject: [util] add a warning into 'heap_sample_every_n_bytes' flag description.
......................................................................
Patch Set 7:
(6 comments)
http://gerrit.cloudera.org:8080/#/c/20716/7//COMMIT_MSG
Commit Message:
http://gerrit.cloudera.org:8080/#/c/20716/7//COMMIT_MSG@9
PS7, Line 9: Parameter heap_sample_every_n_bytes
nit: --heap_sample_every_n_bytes
http://gerrit.cloudera.org:8080/#/c/20716/7//COMMIT_MSG@10
PS7, Line 10: to a value greater than 0
nit: a positive value
http://gerrit.cloudera.org:8080/#/c/20716/7//COMMIT_MSG@11
PS7, Line 11:
Remove it.
http://gerrit.cloudera.org:8080/#/c/20716/7//COMMIT_MSG@12
PS7, Line 12: hold
nit: compete the lock of page heap with other thread?
http://gerrit.cloudera.org:8080/#/c/20716/7//COMMIT_MSG@18
PS7, Line 18: the paramete
nit: --heap_sample_every_n_bytes
http://gerrit.cloudera.org:8080/#/c/20716/7/src/kudu/util/flags.cc
File src/kudu/util/flags.cc:
http://gerrit.cloudera.org:8080/#/c/20716/7/src/kudu/util/flags.cc@99
PS7, Line 99: Warning: Setting this flag to a positive value increases lock contention "
: "in tcmalloc; the lower the value, the higher the lock contention.
It seems better to set --heap_sample_every_n_bytes more larger to lower the lock contention. Can you give some suggestion how large should this parameter should be set to get better performance?
--
To view, visit http://gerrit.cloudera.org:8080/20716
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-MessageType: comment
Gerrit-Change-Id: I00d55126f0cad0ac6cc130576cc45808f96f0a47
Gerrit-Change-Number: 20716
Gerrit-PatchSet: 7
Gerrit-Owner: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Alexey Serbin <al...@apache.org>
Gerrit-Reviewer: Kudu Jenkins (120)
Gerrit-Reviewer: Marton Greber <gr...@gmail.com>
Gerrit-Reviewer: Song Jiacheng <so...@thinkingdata.cn>
Gerrit-Reviewer: Wang Xixu <14...@qq.com>
Gerrit-Comment-Date: Thu, 07 Dec 2023 07:55:17 +0000
Gerrit-HasComments: Yes