You are viewing a plain text version of this content. The canonical link for it is here.
Posted to dev@tomcat.apache.org by ma...@apache.org on 2014/04/26 21:32:15 UTC
svn commit: r1590283 - in /tomcat/trunk:
java/org/apache/tomcat/util/IntrospectionUtils.java
webapps/docs/changelog.xml
Author: markt
Date: Sat Apr 26 19:32:15 2014
New Revision: 1590283
URL: http://svn.apache.org/r1590283
Log:
Fix https://issues.apache.org/bugzilla/show_bug.cgi?id=56441
Raise the visibility of exceptions thrown when a problem is encountered calling a getter or setter on a component attribute from debug to warning.
Modified:
tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
tomcat/trunk/webapps/docs/changelog.xml
Modified: tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java
URL: http://svn.apache.org/viewvc/tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java?rev=1590283&r1=1590282&r2=1590283&view=diff
==============================================================================
--- tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java (original)
+++ tomcat/trunk/java/org/apache/tomcat/util/IntrospectionUtils.java Sat Apr 26 19:32:15 2014
@@ -162,18 +162,15 @@ public final class IntrospectionUtils {
} catch (IllegalArgumentException ex2) {
log.warn("IAE " + o + " " + name + " " + value, ex2);
} catch (SecurityException ex1) {
- if (log.isDebugEnabled())
- log.debug("IntrospectionUtils: SecurityException for " +
- o.getClass() + " " + name + "=" + value + ")", ex1);
+ log.warn("IntrospectionUtils: SecurityException for " +
+ o.getClass() + " " + name + "=" + value + ")", ex1);
} catch (IllegalAccessException iae) {
- if (log.isDebugEnabled())
- log.debug("IntrospectionUtils: IllegalAccessException for " +
- o.getClass() + " " + name + "=" + value + ")", iae);
+ log.warn("IntrospectionUtils: IllegalAccessException for " +
+ o.getClass() + " " + name + "=" + value + ")", iae);
} catch (InvocationTargetException ie) {
ExceptionUtils.handleThrowable(ie.getCause());
- if (log.isDebugEnabled())
- log.debug("IntrospectionUtils: InvocationTargetException for " +
- o.getClass() + " " + name + "=" + value + ")", ie);
+ log.warn("IntrospectionUtils: InvocationTargetException for " +
+ o.getClass() + " " + name + "=" + value + ")", ie);
}
return false;
}
@@ -211,18 +208,15 @@ public final class IntrospectionUtils {
} catch (IllegalArgumentException ex2) {
log.warn("IAE " + o + " " + name, ex2);
} catch (SecurityException ex1) {
- if (log.isDebugEnabled())
- log.debug("IntrospectionUtils: SecurityException for " +
- o.getClass() + " " + name + ")", ex1);
+ log.warn("IntrospectionUtils: SecurityException for " +
+ o.getClass() + " " + name + ")", ex1);
} catch (IllegalAccessException iae) {
- if (log.isDebugEnabled())
- log.debug("IntrospectionUtils: IllegalAccessException for " +
- o.getClass() + " " + name + ")", iae);
+ log.warn("IntrospectionUtils: IllegalAccessException for " +
+ o.getClass() + " " + name + ")", iae);
} catch (InvocationTargetException ie) {
ExceptionUtils.handleThrowable(ie.getCause());
- if (log.isDebugEnabled())
- log.debug("IntrospectionUtils: InvocationTargetException for " +
- o.getClass() + " " + name + ")");
+ log.warn("IntrospectionUtils: InvocationTargetException for " +
+ o.getClass() + " " + name + ")");
}
return null;
}
Modified: tomcat/trunk/webapps/docs/changelog.xml
URL: http://svn.apache.org/viewvc/tomcat/trunk/webapps/docs/changelog.xml?rev=1590283&r1=1590282&r2=1590283&view=diff
==============================================================================
--- tomcat/trunk/webapps/docs/changelog.xml (original)
+++ tomcat/trunk/webapps/docs/changelog.xml Sat Apr 26 19:32:15 2014
@@ -141,6 +141,11 @@
additional locations where, theoretically, a memory leak could occur.
(markt)
</add>
+ <fix>
+ <bug>56441</bug>: Raise the visibility of exceptions thrown when a
+ problem is encountered calling a getter or setter on a component
+ attribute from debug to warning. (markt)
+ </fix>
</changelog>
</subsection>
<subsection name="Coyote">
---------------------------------------------------------------------
To unsubscribe, e-mail: dev-unsubscribe@tomcat.apache.org
For additional commands, e-mail: dev-help@tomcat.apache.org