You are viewing a plain text version of this content. The canonical link for it is here.
Posted to mapreduce-issues@hadoop.apache.org by "Robert Joseph Evans (Created) (JIRA)" <ji...@apache.org> on 2011/11/08 17:25:51 UTC

[jira] [Created] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Old mapred API combiner uses NULL reporter
------------------------------------------

                 Key: MAPREDUCE-3376
                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
             Project: Hadoop Map/Reduce
          Issue Type: Bug
          Components: mrv1, mrv2
    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
            Reporter: Robert Joseph Evans


The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173559#comment-13173559 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Common-trunk-Commit #1457 (See [https://builds.apache.org/job/Hadoop-Common-trunk-Commit/1457/])
    MAPREDUCE-3376. Fixed Task to ensure it passes reporter to combiners using old MR api. Contributed by Subroto Sanyal.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221501
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159958#comment-13159958 ] 

Subroto Sanyal commented on MAPREDUCE-3376:
-------------------------------------------

The testcase failure and findbug comments are unrelated to patch.
The TestCode uses Depricated APIs and for the same *@SuppressWarnings("deprecation")* is also used.
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148301#comment-13148301 ] 

Subroto Sanyal commented on MAPREDUCE-3376:
-------------------------------------------

The OldCombinerRunner gets a valid reference of an reporter while creation(constructor). We can pass the same value instead of passing NULL reporter to:
{code}
combiner.reduce(values.getKey(), values, combineCollector,
              Reporter.NULL)
{code}
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174062#comment-13174062 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Build #114 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Build/114/])
    Merge -c 1221501 from trunk to branch-0.23 to fix MAPREDUCE-3376.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221502
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Mahadev konar (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Mahadev konar updated MAPREDUCE-3376:
-------------------------------------

    Status: Open  (was: Patch Available)

@Subroto,
 Can you please take a look at the failing tests?
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.23.0, 0.20.205.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173572#comment-13173572 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk-Commit #1480 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk-Commit/1480/])
    MAPREDUCE-3376. Fixed Task to ensure it passes reporter to combiners using old MR api. Contributed by Subroto Sanyal.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221501
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173566#comment-13173566 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk-Commit #1530 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk-Commit/1530/])
    MAPREDUCE-3376. Fixed Task to ensure it passes reporter to combiners using old MR api. Contributed by Subroto Sanyal.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221501
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hadoop QA (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13159948#comment-13159948 ] 

Hadoop QA commented on MAPREDUCE-3376:
--------------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12505595/MAPREDUCE-3376.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The applied patch generated 1836 javac compiler warnings (more than the trunk's current 1826 warnings).

    -1 findbugs.  The patch appears to introduce 12 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.mapreduce.v2.TestMRJobsWithHistoryService
                  org.apache.hadoop.mapred.TestMiniMRClientCluster
                  org.apache.hadoop.mapreduce.v2.TestUberAM
                  org.apache.hadoop.mapred.TestClientRedirect

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1366//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1366//artifact/trunk/hadoop-mapreduce-project/patchprocess/newPatchFindbugsWarningshadoop-mapreduce-examples.html
Console output: https://builds.apache.org/job/PreCommit-MAPREDUCE-Build/1366//console

This message is automatically generated.
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13161602#comment-13161602 ] 

Subroto Sanyal commented on MAPREDUCE-3376:
-------------------------------------------

@Mahadev
executed:
./dev-support/test-patch.sh /home/subroto/Desktop/MAPREDUCE-3376.patch --run-tests >> /tmp/patchTest.log

Following is the result for test cases:
{noformat}
    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.fs.TestLocalDirAllocator
                  org.apache.hadoop.io.retry.TestFailoverProxy
                  org.apache.hadoop.fs.TestFileUtil
                  org.apache.hadoop.fs.viewfs.TestViewFsTrash
                  org.apache.hadoop.fs.viewfs.TestFSMainOperationsLocalFileSystem
                  org.apache.hadoop.fs.TestFSMainOperationsLocalFileSystem
{noformat}

The failed testcases are not at all related to patch. May be some env issue. The patch doesn't break any mapred functionality
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173666#comment-13173666 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Build #134 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Build/134/])
    Merge -c 1221501 from trunk to branch-0.23 to fix MAPREDUCE-3376.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221502
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Arun C Murthy (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Arun C Murthy updated MAPREDUCE-3376:
-------------------------------------

          Resolution: Fixed
       Fix Version/s: 0.23.1
    Target Version/s: 0.23.1  (was: 0.23.1, 0.24.0)
              Status: Resolved  (was: Patch Available)

I just committed this. Thanks Subroto!
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subroto Sanyal updated MAPREDUCE-3376:
--------------------------------------

    Fix Version/s: 0.23.1
           Status: Patch Available  (was: Open)

The patch uses the reporter which sent as a reference rather than just using Reporter.NULL
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.23.0, 0.20.205.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Assigned] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Assigned) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subroto Sanyal reassigned MAPREDUCE-3376:
-----------------------------------------

    Assignee: Subroto Sanyal
    
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173565#comment-13173565 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Common-0.23-Commit #310 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/310/])
    Merge -c 1221501 from trunk to branch-0.23 to fix MAPREDUCE-3376.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221502
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13156026#comment-13156026 ] 

Robert Joseph Evans commented on MAPREDUCE-3376:
------------------------------------------------

That is what I saw too, and I thought it would be a simple fix.
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Robert Joseph Evans (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13166578#comment-13166578 ] 

Robert Joseph Evans commented on MAPREDUCE-3376:
------------------------------------------------

The patch looks good to me +1(non-binding)  I reran test-patch myself and the test failures did not show up for me.
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174050#comment-13174050 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Hdfs-trunk #901 (See [https://builds.apache.org/job/Hadoop-Hdfs-trunk/901/])
    MAPREDUCE-3376. Fixed Task to ensure it passes reporter to combiners using old MR api. Contributed by Subroto Sanyal.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221501
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Mahadev konar (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160758#comment-13160758 ] 

Mahadev konar commented on MAPREDUCE-3376:
------------------------------------------

@Subroto,
 I just ran the above tests without the patch, they seems to be running fine. Didnt get a chance to run it with the patch. Are the tests failing for you or is it just the hudson bot?
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173568#comment-13173568 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Hdfs-0.23-Commit #299 (See [https://builds.apache.org/job/Hadoop-Hdfs-0.23-Commit/299/])
    Merge -c 1221501 from trunk to branch-0.23 to fix MAPREDUCE-3376.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221502
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13160796#comment-13160796 ] 

Subroto Sanyal commented on MAPREDUCE-3376:
-------------------------------------------

@Mahadev
I will again look into the testcase(run it) and will put my findings.
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13174096#comment-13174096 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Mapreduce-trunk #934 (See [https://builds.apache.org/job/Hadoop-Mapreduce-trunk/934/])
    MAPREDUCE-3376. Fixed Task to ensure it passes reporter to combiners using old MR api. Contributed by Subroto Sanyal.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221501
Files : 
* /hadoop/common/trunk/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/trunk/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Hudson (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13173586#comment-13173586 ] 

Hudson commented on MAPREDUCE-3376:
-----------------------------------

Integrated in Hadoop-Mapreduce-0.23-Commit #321 (See [https://builds.apache.org/job/Hadoop-Mapreduce-0.23-Commit/321/])
    Merge -c 1221501 from trunk to branch-0.23 to fix MAPREDUCE-3376.

acmurthy : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1221502
Files : 
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/CHANGES.txt
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-core/src/main/java/org/apache/hadoop/mapred/Task.java
* /hadoop/common/branches/branch-0.23/hadoop-mapreduce-project/hadoop-mapreduce-client/hadoop-mapreduce-client-jobclient/src/test/java/org/apache/hadoop/mapreduce/v2/TestMRAppWithCombiner.java

                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Commented] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Commented) (JIRA)" <ji...@apache.org>.
    [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13165940#comment-13165940 ] 

Subroto Sanyal commented on MAPREDUCE-3376:
-------------------------------------------

@Mahadev,
Please let me know if any changes or improvements needs to be made in the patch.
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>             Fix For: 0.23.1
>
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subroto Sanyal updated MAPREDUCE-3376:
--------------------------------------

    Attachment: MAPREDUCE-3376.patch
    
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.20.205.0, 0.23.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

[jira] [Updated] (MAPREDUCE-3376) Old mapred API combiner uses NULL reporter

Posted by "Subroto Sanyal (Updated) (JIRA)" <ji...@apache.org>.
     [ https://issues.apache.org/jira/browse/MAPREDUCE-3376?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Subroto Sanyal updated MAPREDUCE-3376:
--------------------------------------

    Fix Version/s:     (was: 0.23.1)
           Status: Patch Available  (was: Open)

Submitting the same patch again.
                
> Old mapred API combiner uses NULL reporter
> ------------------------------------------
>
>                 Key: MAPREDUCE-3376
>                 URL: https://issues.apache.org/jira/browse/MAPREDUCE-3376
>             Project: Hadoop Map/Reduce
>          Issue Type: Bug
>          Components: mrv1, mrv2
>    Affects Versions: 0.23.0, 0.20.205.0, 0.24.0
>            Reporter: Robert Joseph Evans
>            Assignee: Subroto Sanyal
>         Attachments: MAPREDUCE-3376.patch
>
>
> The OldCombinerRunner class inside Task.java uses a NULL Reporter.  If the combiner code runs for an extended period of time, even with reporting progress as it should, the map task can timeout and be killed.  It appears that the NewCombinerRunner class uses a valid reporter and as such is not impacted by this bug.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira