[GitHub] [incubator-superset] villebro commented on a change in pull request #11325: fix(extra-filters): add logic for identifying applied extra filters

[GitBox <gi...@apache.org>]

villebro commented on a change in pull request #11325:
URL: https://github.com/apache/incubator-superset/pull/11325#discussion_r507612918



##########
File path: superset-frontend/spec/javascripts/explore/components/QueryAndSaveBtns_spec.jsx
##########
@@ -50,7 +50,7 @@ describe('QueryAndSaveButtons', () => {
 
     it('renders buttons with correct text', () => {
       expect(wrapper.find(Button).contains('Run')).toBe(true);
-      expect(wrapper.find(Button).contains(' Save')).toBe(true);
+      expect(wrapper.find(Button).contains('Save')).toBe(true);

Review comment:
       I'm unsure why GH is showing this line (and other similar ones) as changed, as I haven't touched them (the branch is based on `apache:feature/filter-p0` and is up-to-date)




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: notifications-unsubscribe@superset.apache.org
For additional commands, e-mail: notifications-help@superset.apache.org