[GitHub] [royale-asjs] cristallium edited a comment on issue #492: Update GroupBase.as

[GitBox <gi...@apache.org>]

cristallium edited a comment on issue #492: Update GroupBase.as
URL: https://github.com/apache/royale-asjs/pull/492#issuecomment-538134104
 
 
   Hi Harbs,
   As it's first time I'm using push request I have some difficult to use it.
   I wanted to do only one request for prevent currentState to dispatch if set same state but I don't know how to do, so I have done several patch.
   Please note that for file frameworks/projects/Basic/src/main/royale/org/apache/royale/html/MXMLBeadView.as I have done a mistake : I commited directly on develop branch.
   
   And also note that it seem to be missing a ";" the line just after my commits
   
   To anwser your question "Anyone have a style preference on if(false)return vs. if(true{//do stuff}?" personnaly I prefer if (false) return because more less code and more readable code but some people doesn't want a return in a middle of function ... So you can do what you think the best
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services