You are viewing a plain text version of this content. The canonical link for it is here.
Posted to reviews@kudu.apache.org by "Mike Percy (Code Review)" <ge...@cloudera.org> on 2017/01/06 01:08:31 UTC
[kudu-CR] env: Add GetCurrentWorkingDir() and ChangeDir()
Mike Percy has uploaded a new change for review.
http://gerrit.cloudera.org:8080/5629
Change subject: env: Add GetCurrentWorkingDir() and ChangeDir()
......................................................................
env: Add GetCurrentWorkingDir() and ChangeDir()
These are functions that were missing from our Env implementation.
Change-Id: If20ddf477bd923df58be4c0b2730ec8f12d4481a
---
M src/kudu/util/env-test.cc
M src/kudu/util/env.h
M src/kudu/util/env_posix.cc
3 files changed, 45 insertions(+), 0 deletions(-)
git pull ssh://gerrit.cloudera.org:29418/kudu refs/changes/29/5629/1
--
To view, visit http://gerrit.cloudera.org:8080/5629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: newchange
Gerrit-Change-Id: If20ddf477bd923df58be4c0b2730ec8f12d4481a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
[kudu-CR] env: Add GetCurrentWorkingDir() and ChangeDir()
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has abandoned this change.
Change subject: env: Add GetCurrentWorkingDir() and ChangeDir()
......................................................................
Abandoned
--
To view, visit http://gerrit.cloudera.org:8080/5629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: abandon
Gerrit-Change-Id: If20ddf477bd923df58be4c0b2730ec8f12d4481a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
[kudu-CR] env: Add GetCurrentWorkingDir() and ChangeDir()
Posted by "Mike Percy (Code Review)" <ge...@cloudera.org>.
Mike Percy has posted comments on this change.
Change subject: env: Add GetCurrentWorkingDir() and ChangeDir()
......................................................................
Patch Set 1:
(1 comment)
Merging into https://gerrit.cloudera.org/5618
http://gerrit.cloudera.org:8080/#/c/5629/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 896: unique_ptr<char, FreeDeleter> wd(get_current_dir_name()); // GNU extension.
> Is this more or less portable than getcwd(nullptr, 0), which also allocates
Good call. They also support that form: https://developer.apple.com/legacy/library/documentation/Darwin/Reference/ManPages/man3/getcwd.3.html
I'll switch to that.
--
To view, visit http://gerrit.cloudera.org:8080/5629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If20ddf477bd923df58be4c0b2730ec8f12d4481a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-Reviewer: Mike Percy <mp...@apache.org>
Gerrit-HasComments: Yes
[kudu-CR] env: Add GetCurrentWorkingDir() and ChangeDir()
Posted by "Adar Dembo (Code Review)" <ge...@cloudera.org>.
Adar Dembo has posted comments on this change.
Change subject: env: Add GetCurrentWorkingDir() and ChangeDir()
......................................................................
Patch Set 1:
(1 comment)
http://gerrit.cloudera.org:8080/#/c/5629/1/src/kudu/util/env_posix.cc
File src/kudu/util/env_posix.cc:
Line 896: unique_ptr<char, FreeDeleter> wd(get_current_dir_name()); // GNU extension.
Is this more or less portable than getcwd(nullptr, 0), which also allocates memory? Would be good to check on macOS; I'd expect that extension to getcwd() to be more portable than get_current_dir_name().
--
To view, visit http://gerrit.cloudera.org:8080/5629
To unsubscribe, visit http://gerrit.cloudera.org:8080/settings
Gerrit-MessageType: comment
Gerrit-Change-Id: If20ddf477bd923df58be4c0b2730ec8f12d4481a
Gerrit-PatchSet: 1
Gerrit-Project: kudu
Gerrit-Branch: master
Gerrit-Owner: Mike Percy <mp...@apache.org>
Gerrit-Reviewer: Adar Dembo <ad...@cloudera.com>
Gerrit-Reviewer: Kudu Jenkins
Gerrit-HasComments: Yes