You are viewing a plain text version of this content. The canonical link for it is here.
Posted to notifications@couchdb.apache.org by GitBox <gi...@apache.org> on 2020/05/02 21:29:56 UTC

[GitHub] [couchdb] jjrodrig opened a new pull request #2859: Improve js test suite execution time

jjrodrig opened a new pull request #2859:
URL: https://github.com/apache/couchdb/pull/2859


   <!-- Thank you for your contribution!
   
        Please file this form by replacing the Markdown comments
        with your text. If a section needs no action - remove it.
   
        Also remember, that CouchDB uses the Review-Then-Commit (RTC) model
        of code collaboration. Positive feedback is represented +1 from committers
        and negative is a -1. The -1 also means veto, and needs to be addressed
        to proceed. Once there are no objections, the PR can be merged by a
        CouchDB committer.
   
        See: http://couchdb.apache.org/bylaws.html#decisions for more info. -->
   
   ## Overview
   This PR optimizes the time required to process each JS test tagged as skipped or ported to elixir. 
   
   Previous to this PR before each JS test execution it is checked if CouchDB is running even if the test was tagged as skipped or ported. When a test is tagged as skipped or ported it should no be executed so the is running check is not required.
   
   This PR cuts the test execution without checking if CouchDB is running improving the test suite execution time. In my dev host there is a gain of 30 secs.
    
   <!-- Please give a short brief for the pull request,
        what problem it solves or how it makes things better. -->
   
   ## Testing recommendations
   
   ```
    make javascript
   ```
   <!-- Describe how we can test your changes.
        Does it provides any behaviour that the end users
        could notice? -->
   
   ## Related Issues or Pull Requests
   N/A
   <!-- If your changes affects multiple components in different
        repositories please put links to those issues or pull requests here.  -->
   
   ## Checklist
   
   - [X] Code is written and works correctly
   - [ ] Changes are covered by tests
   - [ ] Any new configurable parameters are documented in `rel/overlay/etc/default.ini`
   - [ ] A PR for documentation changes has been made in https://github.com/apache/couchdb-documentation
   


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



[GitHub] [couchdb] jjrodrig commented on pull request #2859: Improve js test suite execution time

Posted by GitBox <gi...@apache.org>.
jjrodrig commented on pull request #2859:
URL: https://github.com/apache/couchdb/pull/2859#issuecomment-623020117


   Thanks @wohali 
   
   I'll backport this to 3.x


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org