[GitHub] [iceberg] rdblue commented on a diff in pull request #6461: Spark-3.3: Store sort-order-id in manifest_entry's data_file

["rdblue (via GitHub)" <gi...@apache.org>]

rdblue commented on code in PR #6461:
URL: https://github.com/apache/iceberg/pull/6461#discussion_r1155370540


##########
spark/v3.3/spark/src/main/java/org/apache/iceberg/spark/source/SparkWrite.java:
##########
@@ -620,20 +626,23 @@ private static class WriterFactory implements DataWriterFactory, StreamingDataWr
     private final Schema writeSchema;
     private final StructType dsSchema;
     private final boolean partitionedFanoutEnabled;
+    private final boolean isOrderedWrite;

Review Comment:
   @ajantha-bhat, I think this should pass the sort order ID that was used instead. There isn't a guarantee that the write used the default sort order. It could be possible to choose the sort order in the future, and some of the actions already allow you to choose.



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org


---------------------------------------------------------------------
To unsubscribe, e-mail: issues-unsubscribe@iceberg.apache.org
For additional commands, e-mail: issues-help@iceberg.apache.org