You are viewing a plain text version of this content. The canonical link for it is here.
Posted to log4j-dev@logging.apache.org by "Mohit Anchlia (JIRA)" <ji...@apache.org> on 2014/09/04 01:39:51 UTC

[jira] [Created] (LOG4J2-812) Blocking state: org.apache​.loggin.lo​g4j.core.p​attern.Dat​ePatternCo​nverter 

Mohit Anchlia created LOG4J2-812:
------------------------------------

             Summary: Blocking state: org.apache​.loggin.lo​g4j.core.p​attern.Dat​ePatternCo​nverter 
                 Key: LOG4J2-812
                 URL: https://issues.apache.org/jira/browse/LOG4J2-812
             Project: Log4j 2
          Issue Type: Bug
    Affects Versions: 2.0.2
            Reporter: Mohit Anchlia


Threads seem to be blocking on class org.apache​.loggin.lo​g4j.core.p​attern.Dat​ePatternCo​nverter. It's short lived but is visible in profiler. It also is adding on to CPU. Here is the mail conversation on the mailing list:

-------------


Ralph Goers ralph.goers@dslextreme.com via logging.apache.org  
 

4:28 PM (10 minutes ago)
 
 


 



to Log4J 

 
 







The converter uses a SimpleDateFormat which is not thread safe and so is synchronized. I am sure there might be minor optimizations that could be done to this

 What I would do is modify DatePatternConverter to
 a) use Java 8’s java.time.format.DateTimeFormatter if running on Java 8
 b) use Joda Time’s DateTimeFormat if it is present.
 c) create a pool of SimpleDateFormat objects and use those.

 Please create a Jira issue for this.

 Ralph



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

---------------------------------------------------------------------
To unsubscribe, e-mail: log4j-dev-unsubscribe@logging.apache.org
For additional commands, e-mail: log4j-dev-help@logging.apache.org