You are viewing a plain text version of this content. The canonical link for it is here.
Posted to commits@jspwiki.apache.org by ju...@apache.org on 2013/01/06 20:46:08 UTC

svn commit: r1429579 - /incubator/jspwiki/trunk/src/org/apache/wiki/search/SearchManager.java

Author: juanpablo
Date: Sun Jan  6 19:46:08 2013
New Revision: 1429579

URL: http://svn.apache.org/viewvc?rev=1429579&view=rev
Log:
- constructor throws a more concrete WikiException (=FilterException)
  
- initialize() logs exceptions instead of calling .printStackTrace()

Modified:
    incubator/jspwiki/trunk/src/org/apache/wiki/search/SearchManager.java

Modified: incubator/jspwiki/trunk/src/org/apache/wiki/search/SearchManager.java
URL: http://svn.apache.org/viewvc/incubator/jspwiki/trunk/src/org/apache/wiki/search/SearchManager.java?rev=1429579&r1=1429578&r2=1429579&view=diff
==============================================================================
--- incubator/jspwiki/trunk/src/org/apache/wiki/search/SearchManager.java (original)
+++ incubator/jspwiki/trunk/src/org/apache/wiki/search/SearchManager.java Sun Jan  6 19:46:08 2013
@@ -25,6 +25,7 @@ import org.apache.commons.lang.time.Stop
 import org.apache.log4j.Logger;
 import org.apache.wiki.*;
 import org.apache.wiki.api.exceptions.FilterException;
+import org.apache.wiki.api.exceptions.WikiException;
 import org.apache.wiki.api.filters.BasicPageFilter;
 import org.apache.wiki.event.WikiEvent;
 import org.apache.wiki.event.WikiEventListener;
@@ -74,7 +75,7 @@ public class SearchManager
      *  @throws WikiException If it cannot be instantiated.
      */
     public SearchManager( WikiEngine engine, Properties properties )
-        throws WikiException
+        throws FilterException
     {
         initialize( engine, properties );
 
@@ -208,13 +209,11 @@ public class SearchManager
         }
         catch (NoRequiredPropertyException e)
         {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            log.error( e.getMessage(), e );
         }
         catch (IOException e)
         {
-            // TODO Auto-generated catch block
-            e.printStackTrace();
+            log.error( e.getMessage(), e );
         }
     }